Skip to content

Commit 890ee81

Browse files
committed
Add lief more unconditionally
Signed-off-by: Cristian Le <[email protected]>
1 parent a8f5f34 commit 890ee81

File tree

4 files changed

+4
-10
lines changed

4 files changed

+4
-10
lines changed

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ test-hatchling = [
6868
test-meta = [
6969
"hatch-fancy-pypi-readme>=22.3",
7070
"setuptools-scm",
71-
"lief; platform_system=='Linux' or platform_system=='Darwin'",
71+
"lief",
7272
]
7373
test-numpy = [
7474
"numpy; python_version<'3.14' and platform_python_implementation!='PyPy' and (platform_system != 'Windows' or platform_machine != 'ARM64')",

src/scikit_build_core/builder/get_requires.py

+1-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import functools
55
import importlib.util
66
import os
7-
import platform
87
import sysconfig
98
from typing import TYPE_CHECKING, Literal
109

@@ -147,9 +146,7 @@ def other_dynamic_requires(self) -> Generator[str, None, None]:
147146
)
148147

149148
if self.settings.wheel.repair.enable:
150-
platform_system = platform.system()
151-
if platform_system in ("Linux", "Darwin"):
152-
yield "lief"
149+
yield "lief"
153150

154151
def dynamic_metadata(self) -> Generator[str, None, None]:
155152
if self.settings.fail:

tests/conftest.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import dataclasses
55
import importlib.util
66
import os
7-
import platform
87
import shutil
98
import subprocess
109
import sys
@@ -53,9 +52,8 @@ def pep518_wheelhouse(tmp_path_factory: pytest.TempPathFactory) -> Path:
5352
"setuptools",
5453
"virtualenv",
5554
"wheel",
55+
"lief",
5656
]
57-
if platform.system() in ("Linux", "Darwin"):
58-
packages.append("lief")
5957

6058
if importlib.util.find_spec("cmake") is not None:
6159
packages.append("cmake")

tests/test_repair_wheel.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,7 @@ def test_full_build(
4545

4646
if not with_isolation:
4747
isolated.install("scikit-build-core")
48-
if platform.system() in ("Linux", "Darwin"):
49-
isolated.install("lief")
48+
isolated.install("lief")
5049
isolated.install("./extern", isolated=with_isolation)
5150

5251
if backend == "pip":

0 commit comments

Comments
 (0)