Avoid retrying for 5 minutes after failed key retrieval.

bbockelm · bbockelm · commit 6865e3bebb18 · 2022-10-31T16:40:16.000-05:00
diff --git a/src/scitokens_internal.cpp b/src/scitokens_internal.cpp
@@ -584,7 +584,9 @@ Validator::get_public_key_pem(const std::string &issuer, const std::string &kid,
                 get_public_keys_from_web(issuer, SimpleCurlGet::default_timeout, keys, next_update, expires);
                 store_public_keys(issuer, keys, next_update, expires);
             } catch (std::runtime_error &) {
-                // ignore the exception: we have a valid set of keys already/
+                // ignore the exception: we have a valid set of keys already.  However, we don't want to continuously
+                // hammer the upstream server which is not currently working ... move forward the next_update by 5 minutes.
+                store_public_keys(issuer, keys, now + 300, expires);
             }
         }
     } else {

Original file line number	Diff line number	Diff line change
`@@ -584,7 +584,9 @@ Validator::get_public_key_pem(const std::string &issuer, const std::string &kid,`
`584`	`584`	`get_public_keys_from_web(issuer, SimpleCurlGet::default_timeout, keys, next_update, expires);`
`585`	`585`	`store_public_keys(issuer, keys, next_update, expires);`
`586`	`586`	`} catch (std::runtime_error &) {`
`587`		`- // ignore the exception: we have a valid set of keys already/`
	`587`	`+ // ignore the exception: we have a valid set of keys already. However, we don't want to continuously`
	`588`	`+ // hammer the upstream server which is not currently working ... move forward the next_update by 5 minutes.`
	`589`	`+ store_public_keys(issuer, keys, now + 300, expires);`
`588`	`590`	`}`
`589`	`591`	`}`
`590`	`592`	`} else {`