Skip to content

Commit 43bb5d9

Browse files
committed
create default messages for Http Exceptions
1 parent 8b01cf7 commit 43bb5d9

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

tests/test_exceptions.py

+3
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
def test_http_error_init():
1010
exc = HttpError()
1111
assert exc.request is None
12+
assert exc.args
1213

1314
request = HttpRequest(URL)
1415
exc = HttpError(request=request)
@@ -18,6 +19,7 @@ def test_http_error_init():
1819
def test_http_request_error_init():
1920
exc = HttpRequestError()
2021
assert exc.request is None
22+
assert exc.args
2123

2224
request = HttpRequest(URL)
2325
exc = HttpRequestError(request=request)
@@ -32,6 +34,7 @@ def test_http_response_error_init():
3234
exc = HttpResponseError()
3335
assert exc.request is None
3436
assert exc.response is None
37+
assert exc.args
3538

3639
request = HttpRequest(URL)
3740
response = HttpResponse(URL, b"")

web_poet/exceptions/http.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ class HttpError(IOError):
2424

2525
def __init__(self, msg: str = None, request: HttpRequest = None):
2626
self.request = request
27+
if msg is None:
28+
msg = f"An Error ocurred when executing this HTTP Request: {self.request}"
2729
super().__init__(msg)
2830

2931

@@ -61,6 +63,8 @@ class HttpResponseError(HttpError):
6163
:type response: HttpResponse
6264
"""
6365

64-
def __init__(self, msg: str = None, response: HttpResponse = None, **kwargs):
66+
def __init__(self, msg: str = None, response: HttpResponse = None, request: HttpRequest = None):
6567
self.response = response
66-
super().__init__(msg, **kwargs)
68+
if msg is None:
69+
msg = f"Unexpected HTTP Response received: {self.response}"
70+
super().__init__(msg, request=request)

0 commit comments

Comments
 (0)