Merge pull request #23 from scribd/COREINF-8170-test-build-new-lambda-5

fix: add more logs

Author: dmytrol-scribd

lambda_function.rb

@@ -75,7 +75,12 @@ def lambda_handler(event: {}, context: {})
       metricname: ENV.fetch('METRICNAME', 'elasticache.slowlog')
     )
 
-    @slowlog_check.update_metadatas
+    if ENV.fetch('SKIP_METADATA_UPDATE', 'false').casecmp('true').zero?
+      LOGGER.warn 'Skipping Datadog metadata update due to SKIP_METADATA_UPDATE=true'
+    else
+      LOGGER.info 'Updating Datadog metric metadata'
+      @slowlog_check.update_metadatas
+    end
   end
 
   @slowlog_check.ship_slowlogs

lib/slowlog_check.rb

@@ -319,9 +319,13 @@ def get_metadatas
       count
     ].map do |metric|
       name = @metricname + '.' + metric
+      LOGGER.debug "Fetching metadata for #{name}"
       @ddog.get_metadata(name)[1]
            .merge('name' => name)
     end
+  rescue StandardError => e
+    LOGGER.warn "Unable to fetch metric metadata: #{e.class} #{e.message}"
+    []
   end
 
   def diff_metadatas
@@ -331,11 +335,16 @@ def diff_metadatas
   def update_metadatas
     diff_metadatas.each do |metadata|
       name = metadata.delete('name')
-      resp = @ddog.update_metadata(
-        name,
-        metadata.transform_keys(&:to_sym)
-      )
-      LOGGER.info "Updating metadata for #{name} #{status_or_error(resp)}"
+      LOGGER.info "Updating metadata for #{name}"
+      begin
+        resp = @ddog.update_metadata(
+          name,
+          metadata.transform_keys(&:to_sym)
+        )
+        LOGGER.info "Updating metadata for #{name} #{status_or_error(resp)}"
+      rescue StandardError => e
+        LOGGER.error "Failed to update metadata for #{name}: #{e.class} #{e.message}"
+      end
     end
   end
 end