Skip to content

Commit bb24966

Browse files
authored
Update scale-bits and scale-encode (#599)
* update scale-bits and scale-encode * add Box import * fix scale-decode
1 parent 3162233 commit bb24966

File tree

3 files changed

+18
-26
lines changed

3 files changed

+18
-26
lines changed

Cargo.lock

Lines changed: 12 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

node-api/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ either = { version = "1.6.1", default-features = false }
1717
frame-metadata = { version = "15.1", default-features = false, features = ["v14", "v15-unstable", "serde_full", "decode"] }
1818
hex = { version = "0.4.3", default-features = false }
1919
log = { version = "0.4.14", default-features = false }
20+
scale-bits = { version = "0.4.0", default-features = false, features = ["scale-info", "serde"] }
2021
scale-info = { version = "2.0.1", features = ["derive", "decode", "bitvec"], default-features = false }
2122
serde = { version = "1.0.136", features = ["derive"], default-features = false }
2223
serde_json = { version = "1.0.79", default-features = false, features = ["alloc"] }
2324

2425
# scale
25-
scale-bits = { default-features = false, features = ["scale-info", "serde"], git = "https://github.com/haerdib/scale-bits.git", branch = "bh/no-std" }
2626
scale-decode = { default-features = false, features = ["primitive-types", "derive"], git = "https://github.com/scs/scale-decode.git", branch = "no-std" }
27-
scale-encode = { default-features = false, features = ["bits", "primitive-types", "derive"], git = "https://github.com/scs/scale-encode.git", branch = "no-std" }
27+
scale-encode = { default-features = false, features = ["bits", "primitive-types", "derive"], git = "https://github.com/paritytech/scale-encode.git" }
2828

2929
# substrate
3030
sp-core = { default-features = false, features = ["full_crypto", "serde"], git = "https://github.com/paritytech/substrate.git", branch = "master" }

node-api/src/scale_value/encode.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
//! Based on https://github.com/paritytech/scale-value/blob/430bfaf8f302dfcfc45d8d63c687628fd9b7fc25/src/scale_impls/encode.rs
1010
1111
use crate::scale_value::{Composite, Primitive, Value, ValueDef, Variant};
12-
use alloc::{string::ToString, vec::Vec};
12+
use alloc::{boxed::Box, string::ToString, vec::Vec};
1313
use codec::{Compact, Encode};
1414
use scale_encode::{
1515
error::{ErrorKind, Kind},
@@ -45,7 +45,9 @@ impl<T> EncodeAsFields for Value<T> {
4545
) -> Result<(), Error> {
4646
match &self.value {
4747
ValueDef::Composite(composite) => composite.encode_as_fields_to(fields, types, out),
48-
_ => Err(Error::custom("Cannot encode non-composite Value shape into fields")),
48+
_ => Err(Error::new(ErrorKind::Custom(Box::new(
49+
"Cannot encode non-composite Value shape into fields".to_string(),
50+
)))),
4951
}
5052
}
5153
}

0 commit comments

Comments
 (0)