Skip to content

Commit 0b61d2a

Browse files
committed
[#597] Addressing code review comments pt 1.
1 parent 25f36d0 commit 0b61d2a

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

core/src/main/java/com/datastax/oss/driver/internal/core/channel/ChannelFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ private void connect(
257257
cf -> {
258258
if (connectFuture.isSuccess()) {
259259
Channel channel = connectFuture.channel();
260-
DriverChannel driverChannel = // driver channel init
260+
DriverChannel driverChannel =
261261
new DriverChannel(endPoint, channel, context.getWriteCoalescer(), currentVersion);
262262
// If this is the first successful connection, remember the protocol version and
263263
// cluster name for future connections.

core/src/main/java/com/datastax/oss/driver/internal/core/channel/ProtocolInitHandler.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -435,6 +435,13 @@ private void maybeSwitchToModernFraming() {
435435
}
436436
}
437437

438+
/**
439+
* If <code>SCYLLA_USE_METADATA_ID</code> feature was negotiated we need to replace {@link
440+
* FrameEncoder} and {@link FrameDecoder} handlers with instances aware of a negotiated protocol
441+
* feature.
442+
*
443+
* @param metadataIdEnabled indicates if feature is successfully negotiated
444+
*/
438445
private void maybeUpdatePipelineWithProtocolOptions(boolean metadataIdEnabled) {
439446
if (metadataIdEnabled) {
440447
ProtocolFeatures protocolFeatures =

0 commit comments

Comments
 (0)