more examples

Author: sebyx07

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    binary_search (1.0.0)
+    ruby_binary_search (1.0.0)
 
 GEM
   remote: https://rubygems.org/
@@ -106,12 +106,12 @@ PLATFORMS
   x86_64-linux
 
 DEPENDENCIES
-  binary_search!
   lefthook (~> 1.7, >= 1.7.4)
   pry (~> 0.14.2)
   rake (~> 13.0)
   rspec (~> 3.0)
   rubocop-rails_config (~> 1.16)
+  ruby_binary_search!
 
 BUNDLED WITH
    2.5.14

README.md

@@ -53,6 +53,33 @@ puts list.to_a  # Output: [2, 3, 3, 4, 5, 5, 5, 6, 7, 9]
 puts list.min  # Output: 2
 puts list.max  # Output: 9
 ```
+Custom objects
+```ruby
+require 'binary_search'
+class Person
+  attr_accessor :name, :age
+
+  def initialize(name, age)
+    @name = name
+    @age = age
+  end
+
+  def <=>(other)
+    @age <=> other.age
+  end
+end
+
+
+list = BinarySearch::List.new([
+  Person.new('Alice', 25),
+  Person.new('Bob', 30),
+  Person.new('Charlie', 20),
+  Person.new('David', 35)
+])
+
+puts list.to_a.map(&:name)  # Output: ["Charlie", "Alice", "Bob", "David"]
+```
+
 ## Why is BinarySearch better than normal search? 🏆
 
 - Speed: For large datasets, binary search is significantly faster than linear search. While a normal array search takes O(n) time, BinarySearch takes only O(log n) time. 🐇

binary_search.gemspec

@@ -3,13 +3,13 @@
 require_relative 'lib/binary_search/version'
 
 Gem::Specification.new do |spec|
-  spec.name = 'binary_search'
+  spec.name = 'ruby_binary_search'
   spec.version = BinarySearch::VERSION
   spec.authors = ['sebi']
   spec.email = ['[email protected]']
 
-  spec.summary = 'Binary search list implemented in ruby using red-black tree'
-  spec.description = 'Binary search list implemented in ruby using red-black tree'
+  spec.summary = 'Binary search list implemented in ruby using red-black self-balancing tree'
+  spec.description = 'Binary search list implemented in ruby using red-black self-balancing tree'
   spec.homepage = 'https://github.com/sebyx07/binary_search'
   spec.license = 'MIT'
   spec.required_ruby_version = '>= 3.0.0'

lib/binary_search/red_black_tree.rb

@@ -44,17 +44,20 @@ def insert(key)
         parent = nil
         while current
           parent = current
-          if key < current.key
+          comparison = key <=> current.key
+          case comparison
+          when -1
             current = current.left
-          elsif key > current.key
+          when 1
             current = current.right
           else
             # For duplicates, we'll add to the right
             current = current.right
           end
         end
         new_node.parent = parent
-        if key <= parent.key
+        comparison = key <=> parent.key
+        if comparison <= 0
           parent.left = new_node
         else
           parent.right = new_node
@@ -106,8 +109,9 @@ def update(old_key, new_key)
     def find(key)
       current = @root
       while current
-        return current if current.key == key
-        current = key < current.key ? current.left : current.right
+        comparison = key <=> current.key
+        return current if comparison == 0
+        current = comparison < 0 ? current.left : current.right
       end
       nil
     end

spec/binary_search/example_spec.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+RSpec.describe 'custom classes' do
+  class Person
+    attr_accessor :name, :age
+
+    def initialize(name, age)
+      @name = name
+      @age = age
+    end
+
+    def <=>(other)
+      @age <=> other.age
+    end
+  end
+
+  let(:list) { BinarySearch::List.new }
+
+  it 'works with custom classes' do
+    list.push(Person.new('Alice', 20))
+    list.push(Person.new('Bob', 30))
+    list.push(Person.new('Charlie', 25))
+
+    expect(list.to_a.map(&:name)).to eq(%w[Alice Charlie Bob])
+    expect(list.to_a.map(&:age)).to eq([20, 25, 30])
+  end
+end