Fix timeout test

Author: varadarajan-tw

packages/destination-actions/src/destinations/sftp/__tests__/client.test.ts

@@ -1,3 +1,4 @@
+import { DEFAULT_REQUEST_TIMEOUT } from '@segment/actions-core'
 import { normalizeSSHKey, testSFTPConnection, uploadSFTP } from '../client'
 import { SFTP_DEFAULT_PORT } from '../constants'
 import { Settings } from '../generated-types'
@@ -309,6 +310,7 @@ MIIEpAIBAAKCAQEA1234567890
 
   describe('testSFTPConnection', () => {
     beforeEach(() => {
+      jest.useRealTimers()
       jest.clearAllMocks()
       jest.clearAllTimers()
     })
@@ -440,16 +442,20 @@ MN
         expect(Client.prototype.end).toHaveBeenCalled()
       })
 
-      // This test is skipped because it can slow down the CI
-      it.skip('should throw timeout error when operation takes too long', async () => {
+      it('should throw timeout error when operation takes too long', async () => {
+        jest.useFakeTimers()
         Client.prototype.connect = jest.fn().mockImplementation(() => new Promise((r) => setTimeout(r, 11500)))
         Client.prototype.list = jest.fn().mockResolvedValue([])
         Client.prototype.end = jest.fn().mockResolvedValue(undefined)
 
-        await expect(testSFTPConnection(passwordSettings)).rejects.toThrow(
-          'Request timed out before receiving a response'
-        )
-      }, 12000)
+        // Start the async operation
+        const promise = testSFTPConnection(passwordSettings)
+
+        // Advance timers to trigger the timeout
+        jest.advanceTimersByTime(DEFAULT_REQUEST_TIMEOUT)
+
+        await expect(promise).rejects.toThrow('SFTP connection timed out')
+      })
 
       it('should handle connection errors with cleanup', async () => {
         const connectionError = new Error('Connection refused')

packages/destination-actions/src/destinations/sftp/sftp-wrapper.ts

@@ -107,7 +107,7 @@ export class SFTPWrapper {
 
         processWrites()
           .then(resolve)
-          .catch(resolve)
+          .catch(reject)
           .finally(() => {
             // we don't care if close fails here because we expect the caller to call sftp.end() eventually
             this.client?.close(handle, (closeErr) => {