STRATCONN-6152: Fix batching support for editContactInfo function (#3211)

* STRATCONN-6152: Fix batching support for editContactInfo function

* address review comment

Author: abhandage

packages/destination-actions/src/destinations/first-party-dv360/addToAudContactInfo/_tests_/index.test.ts

@@ -77,4 +77,76 @@ describe('First-Party-dv360.addToAudContactInfo', () => {
       '"{\\"advertiserId\\":\\"1234567890\\",\\"addedContactInfoList\\":{\\"contactInfos\\":[{\\"hashedEmails\\":\\"584c4423c421df49955759498a71495aba49b8780eb9387dff333b6f0982c777\\",\\"hashedPhoneNumbers\\":\\"422ce82c6fc1724ac878042f7d055653ab5e983d186e616826a72d4384b68af8\\",\\"zipCodes\\":\\"12345\\",\\"hashedFirstName\\":\\"96d9632f363564cc3032521409cf22a852f2032eec099ed5967c0d000cec607a\\",\\"hashedLastName\\":\\"799ef92a11af918e3fb741df42934f3b568ed2d93ac1df74f1b8d41a27932a6f\\",\\"countryCode\\":\\"US\\"}],\\"consent\\":{\\"adUserData\\":\\"CONSENT_STATUS_GRANTED\\",\\"adPersonalization\\":\\"CONSENT_STATUS_GRANTED\\"}}}"'
     )
   })
+
+  it('should batch multiple payloads into a single request when enable_batching is true', async () => {
+    nock('https://displayvideo.googleapis.com/v3/firstAndThirdPartyAudiences')
+      .post('/1234567890:editCustomerMatchMembers')
+      .reply(200, { success: true })
+
+    const events = createBatchTestEvents(createContactList)
+    const responses = await testDestination.testBatchAction('addToAudContactInfo', {
+      events: events,
+      mapping: {
+        emails: ['584c4423c421df49955759498a71495aba49b8780eb9387dff333b6f0982c777'],
+        phoneNumbers: ['422ce82c6fc1724ac878042f7d055653ab5e983d186e616826a72d4384b68af8'],
+        zipCodes: ['12345'],
+        firstName: '96d9632f363564cc3032521409cf22a852f2032eec099ed5967c0d000cec607a',
+        lastName: '799ef92a11af918e3fb741df42934f3b568ed2d93ac1df74f1b8d41a27932a6f',
+        countryCode: 'US',
+        external_id: '1234567890',
+        advertiser_id: '1234567890',
+        enable_batching: true,
+        batch_size: 2
+      }
+    })
+
+    const requestBody = JSON.parse(String(responses[0].options.body))
+    expect(requestBody.addedContactInfoList.contactInfos.length).toBe(2)
+    expect(requestBody.addedContactInfoList.contactInfos[0].hashedEmails).toBeDefined()
+    expect(requestBody.addedContactInfoList.contactInfos[1].hashedEmails).toBeDefined()
+    // Optionally, check that the emails are correctly hashed and correspond to the input
+  })
 })
+
+export type BatchContactListItem = {
+  id?: string
+  email: string
+  firstname: string
+  lastname: string
+}
+
+export const createBatchTestEvents = (batchContactList: BatchContactListItem[]) =>
+  batchContactList.map((contact) =>
+    createTestEvent({
+      type: 'identify',
+      traits: {
+        email: contact.email,
+        firstname: contact.firstname,
+        lastname: contact.lastname,
+        address: {
+          city: 'San Francisco',
+          country: 'USA',
+          postal_code: '600001',
+          state: 'California',
+          street: 'Vancover st'
+        },
+        graduation_date: 1664533942262,
+        company: 'Some Company',
+        phone: '+13134561129',
+        website: 'somecompany.com'
+      }
+    })
+  )
+
+const createContactList: BatchContactListItem[] = [
+  {
+    email: '[email protected]',
+    firstname: 'User',
+    lastname: 'One'
+  },
+  {
+    email: '[email protected]',
+    firstname: 'User',
+    lastname: 'Two'
+  }
+]

packages/destination-actions/src/destinations/first-party-dv360/functions.ts

@@ -125,53 +125,69 @@ export async function editDeviceMobileIds(
   return response.data
 }
 
-export async function editContactInfo(
-  request: RequestClient,
-  payloads: Payload[],
-  operation: 'add' | 'remove',
-  statsContext?: StatsContext
-) {
-  const payload = payloads[0]
-  const audienceId = payloads[0].external_id
-
-  //Check if one of the required identifiers exists otherwise drop the event
-  if (
-    payload.emails === undefined &&
-    payload.phoneNumbers === undefined &&
-    payload.firstName === undefined &&
-    payload.lastName === undefined
-  ) {
-    return
-  }
-
-  //Format the endpoint
-  const endpoint = DV360API + '/' + audienceId + ':editCustomerMatchMembers'
-
-  // Prepare the request payload
-  const contactInfoList = {
-    contactInfos: [processPayload(payload)],
+// Helper to build contactInfoList
+function buildContactInfoList(contactInfos: Record<string, string>[]): {
+  contactInfos: Record<string, string>[]
+  consent: { adUserData: string; adPersonalization: string }
+} {
+  return {
+    contactInfos,
     consent: {
       adUserData: CONSENT_STATUS_GRANTED,
       adPersonalization: CONSENT_STATUS_GRANTED
     }
   }
+}
 
-  // Convert the payload to string if needed
-  const requestPayload = JSON.stringify({
-    advertiserId: payload.advertiser_id,
+// Helper to build request payload
+function buildRequestPayload(
+  advertiserId: string,
+  contactInfoList: {
+    contactInfos: Record<string, string>[]
+    consent: { adUserData: string; adPersonalization: string }
+  },
+  operation: 'add' | 'remove'
+) {
+  return JSON.stringify({
+    advertiserId,
     ...(operation === 'add' ? { addedContactInfoList: contactInfoList } : {}),
     ...(operation === 'remove' ? { removedContactInfoList: contactInfoList } : {})
   })
+}
 
+export async function editContactInfo(
+  request: RequestClient,
+  payloads: Payload[],
+  operation: 'add' | 'remove',
+  statsContext?: StatsContext
+) {
+  if (!payloads || payloads.length === 0) return
+
+  // TODO: remove this check, the framework should handle this
+  const validPayloads = payloads.filter(
+    (payload) =>
+      payload.emails !== undefined ||
+      payload.phoneNumbers !== undefined ||
+      payload.firstName !== undefined ||
+      payload.lastName !== undefined
+  )
+  if (validPayloads.length === 0) return
+
+  // Assume all payloads are for the same audience/advertiser (use first)
+  const { external_id: audienceId, advertiser_id: advertiserId } = validPayloads[0]
+  if (!audienceId || !advertiserId) {
+    throw new IntegrationError('Missing required audience or advertiser ID', 'MISSING_REQUIRED_FIELD', 400)
+  }
+  const contactInfos = validPayloads.map(processPayload)
+  const contactInfoList = buildContactInfoList(contactInfos)
+  const requestPayload = buildRequestPayload(advertiserId, contactInfoList, operation)
+  const endpoint = DV360API + '/' + audienceId + ':editCustomerMatchMembers'
   const response = await request<DV360editCustomerMatchResponse>(endpoint, {
     method: 'POST',
-    headers: {
-      'Content-Type': 'application/json; charset=utf-8'
-    },
+    headers: { 'Content-Type': 'application/json; charset=utf-8' },
     body: requestPayload
   })
-
-  statsContext?.statsClient?.incr('addCustomerMatchMembers.success', 1, statsContext?.tags)
+  statsContext?.statsClient?.incr('addCustomerMatchMembers.success', contactInfos.length, statsContext?.tags)
   return response.data
 }