add S3 IAM validation feature flag

Author: nk1107

packages/destination-actions/src/destinations/liveramp-audiences/__tests__/liveramp.test.ts

@@ -2,7 +2,11 @@ import nock from 'nock'
 import { createTestIntegration, PayloadValidationError, SegmentEvent } from '@segment/actions-core'
 import Destination from '../index'
 import fs from 'fs'
-import { LIVERAMP_MIN_RECORD_COUNT, LIVERAMP_ENABLE_COMPRESSION_FLAG_NAME } from '../properties'
+import {
+  LIVERAMP_MIN_RECORD_COUNT,
+  LIVERAMP_ENABLE_COMPRESSION_FLAG_NAME,
+  LIVERAMP_S3_IAM_VALIDATION_FLAG_NAME
+} from '../properties'
 
 const testDestination = createTestIntegration(Destination)
 
@@ -359,6 +363,9 @@ describe('Liveramp Audiences', () => {
           settings: {
             __segment_internal_engage_force_full_sync: true,
             __segment_internal_engage_batch_sync: true
+          },
+          features: {
+            [LIVERAMP_S3_IAM_VALIDATION_FLAG_NAME]: true
           }
         })
         // Should not reach here
@@ -393,6 +400,9 @@ describe('Liveramp Audiences', () => {
           settings: {
             __segment_internal_engage_force_full_sync: true,
             __segment_internal_engage_batch_sync: true
+          },
+          features: {
+            [LIVERAMP_S3_IAM_VALIDATION_FLAG_NAME]: true
           }
         })
         // Should not reach here
@@ -428,6 +438,9 @@ describe('Liveramp Audiences', () => {
           settings: {
             __segment_internal_engage_force_full_sync: true,
             __segment_internal_engage_batch_sync: true
+          },
+          features: {
+            [LIVERAMP_S3_IAM_VALIDATION_FLAG_NAME]: true
           }
         })
         // Should not reach here
@@ -463,6 +476,9 @@ describe('Liveramp Audiences', () => {
           settings: {
             __segment_internal_engage_force_full_sync: true,
             __segment_internal_engage_batch_sync: true
+          },
+          features: {
+            [LIVERAMP_S3_IAM_VALIDATION_FLAG_NAME]: true
           }
         })
         // Should not reach here

packages/destination-actions/src/destinations/liveramp-audiences/audienceEnteredS3/index.ts

@@ -5,7 +5,8 @@ import { sendEventToAWS } from '../awsClient'
 import {
   LIVERAMP_MIN_RECORD_COUNT,
   LIVERAMP_LEGACY_FLOW_FLAG_NAME,
-  LIVERAMP_ENABLE_COMPRESSION_FLAG_NAME
+  LIVERAMP_ENABLE_COMPRESSION_FLAG_NAME,
+  LIVERAMP_S3_IAM_VALIDATION_FLAG_NAME
 } from '../properties'
 
 import type { Settings } from '../generated-types'
@@ -145,7 +146,10 @@ async function processData(input: ProcessDataInput<Payload>, subscriptionMetadat
 
   // skip for legacy flow to avoid snapshot issues
   if (!(input.features && input.features[LIVERAMP_LEGACY_FLOW_FLAG_NAME] === true)) {
-    await validateS3Permissions(input.payloads[0], input.request)
+    // only validate S3 permissions when the validation flag is enabled
+    if (input.features && input.features[LIVERAMP_S3_IAM_VALIDATION_FLAG_NAME] === true) {
+      await validateS3Permissions(input.payloads[0], input.request)
+    }
   }
 
   // validate s3 path

packages/destination-actions/src/destinations/liveramp-audiences/audienceEnteredS3/s3.ts

@@ -152,12 +152,7 @@ async function validateS3Permissions(
   payload: Payload,
   request: <Data = unknown>(url: string, options?: RequestOptions) => Promise<ModifiedResponse<Data>>
 ) {
-  if (
-    !payload.s3_aws_access_key ||
-    !payload.s3_aws_secret_key ||
-    !payload.s3_aws_bucket_name ||
-    !payload.s3_aws_region
-  ) {
+  if (!payload.s3_aws_access_key || !payload.s3_aws_secret_key || !payload.s3_aws_bucket_name) {
     throw new PayloadValidationError('Missing required S3 credentials.')
   }
 

packages/destination-actions/src/destinations/liveramp-audiences/properties.ts

@@ -2,7 +2,7 @@ export const ACTION_SLUG = 'actions-liveramp-audiences'
 
 export const LIVERAMP_LEGACY_FLOW_FLAG_NAME = 'actions-liveramp-audiences-legacy-flow'
 export const LIVERAMP_MIN_RECORD_COUNT = 25
-
+export const LIVERAMP_S3_IAM_VALIDATION_FLAG_NAME = 'actions-liveramp-audiences-validate-s3-IAM'
 export const LIVERAMP_SFTP_SERVER = 'files.liveramp.com'
 export const LIVERAMP_SFTP_PORT = 22
 export const LIVERAMP_ENABLE_COMPRESSION_FLAG_NAME = 'actions-liveramp-audiences-enable-compression'