Skip to content

Commit 03a4fd9

Browse files
committed
Update comments and remove an unnecessary method return
1 parent 6841882 commit 03a4fd9

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

seleniumbase/core/s3_manager.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
"""
2-
Manager for dealing with uploading/managing files on S3
2+
Manager for dealing with uploading/managing files on Amazon S3
33
"""
44
from boto.s3.connection import S3Connection
55
from boto.s3.key import Key
@@ -10,7 +10,7 @@
1010

1111
class S3LoggingBucket(object):
1212
"""
13-
A class to upload log files from tests to S3.
13+
A class to upload log files from tests to Amazon S3.
1414
Those files can then be shared easily.
1515
"""
1616

@@ -35,7 +35,7 @@ def get_bucket(self):
3535

3636
def upload_file(self, file_name, file_path):
3737
""" Upload a given file from the file_path to the bucket
38-
with the new name/path file_name. """
38+
with the new name/path file_name. """
3939
upload_key = Key(bucket=self.bucket, name=file_name)
4040
content_type = "text/plain"
4141
if file_name.endswith(".html"):
@@ -53,11 +53,10 @@ def upload_file(self, file_name, file_path):
5353
upload_key.make_public()
5454
except Exception:
5555
pass
56-
return file_name
5756

5857
def upload_index_file(self, test_address, timestamp):
59-
""" Create an index.html file with links to all the log files we
60-
just uploaded. """
58+
""" Create an index.html file with links to all the log files
59+
that were just uploaded. """
6160
global already_uploaded_files
6261
already_uploaded_files = list(set(already_uploaded_files))
6362
already_uploaded_files.sort()
@@ -75,7 +74,7 @@ def upload_index_file(self, test_address, timestamp):
7574

7675
def save_uploaded_file_names(self, files):
7776
""" Keep a record of all file names that've been uploaded. Upload log
78-
files related to each test after its execution. Once done, use
79-
already_uploaded_files to create an index file. """
77+
files related to each test after its execution. Once done, use
78+
already_uploaded_files to create an index file. """
8079
global already_uploaded_files
8180
already_uploaded_files.extend(files)

0 commit comments

Comments
 (0)