test: add coverage for the otpUrl case

Note: this does not yet assert that the OTP was actually sent over to npm.

Author: dominykas

lib/publish.js

@@ -19,8 +19,10 @@ module.exports = async ({npmPublish, pkgRoot, otpUrl}, pkg, context) => {
     const registry = getRegistry(pkg, context);
     let otpArgs = [];
     if (otpUrl) {
+      logger.log('Retrieving OTP from a remote URL...');
       const res = await fetch(otpUrl);
       otpArgs = ['--otp', await res.text()];
+      logger.log('OTP received');
     }
 
     logger.log('Publishing version %s to npm registry', version);

test/helpers/otp-server.js

@@ -0,0 +1,27 @@
+import http from 'http';
+
+let server;
+
+async function start() {
+  server = http.createServer((req, res) => {
+    res.statusCode = 200;
+    res.setHeader('Content-Type', 'text/plain');
+    res.end('this-is-my-otp');
+  });
+
+  return new Promise(resolve => {
+    server.listen(0, '127.0.0.1', () => resolve(server));
+  });
+}
+
+async function stop() {
+  return new Promise(resolve => {
+    server.close(() => resolve());
+  });
+}
+
+function address() {
+  return server.address();
+}
+
+export default {start, stop, address};

test/integration.test.js

@@ -7,6 +7,7 @@ import tempy from 'tempy';
 import clearModule from 'clear-module';
 import {WritableStreamBuffer} from 'stream-buffers';
 import npmRegistry from './helpers/npm-registry';
+import otpServer from './helpers/otp-server';
 
 /* eslint camelcase: ["error", {properties: "never"}] */
 
@@ -23,6 +24,8 @@ const testEnv = {
 test.before(async () => {
   // Start the local NPM registry
   await npmRegistry.start();
+  // Stop the test OTP server
+  await otpServer.start();
 });
 
 test.beforeEach(t => {
@@ -39,6 +42,8 @@ test.beforeEach(t => {
 test.after.always(async () => {
   // Stop the local NPM registry
   await npmRegistry.stop();
+  // Stop the test OTP server
+  await otpServer.start();
 });
 
 test('Skip npm auth verification if "npmPublish" is false', async t => {
@@ -285,6 +290,34 @@ test('Publish the package on a dist-tag', async t => {
   t.is((await execa('npm', ['view', pkg.name, 'version'], {cwd, env: testEnv})).stdout, '1.0.0');
 });
 
+test('Publish the package with OTP', async t => {
+  const cwd = tempy.directory();
+  const env = npmRegistry.authEnv;
+  const pkg = {name: 'publish-otp', version: '0.0.0', publishConfig: {registry: npmRegistry.url}};
+  await outputJson(path.resolve(cwd, 'package.json'), pkg);
+
+  const {port, address} = otpServer.address();
+  const result = await t.context.m.publish(
+    {
+      otpUrl: `http://${address}:${port}/otp`,
+    },
+    {
+      cwd,
+      env,
+      options: {},
+      stdout: t.context.stdout,
+      stderr: t.context.stderr,
+      logger: t.context.logger,
+      nextRelease: {version: '1.0.0'},
+    }
+  );
+
+  t.deepEqual(result, {name: 'npm package (@latest dist-tag)', url: undefined});
+  t.is((await readJson(path.resolve(cwd, 'package.json'))).version, '1.0.0');
+  t.false(await pathExists(path.resolve(cwd, `${pkg.name}-1.0.0.tgz`)));
+  t.is((await execa('npm', ['view', pkg.name, 'version'], {cwd, env: testEnv})).stdout, '1.0.0');
+});
+
 test('Publish the package from a sub-directory', async t => {
   const cwd = tempy.directory();
   const env = npmRegistry.authEnv;