Skip to content

Commit 2b5f9c0

Browse files
authored
fix: Donot bundle chat sdk with uikit compiled code (#323)
Compiled UIKit code that is distributed through npm shouldnt have Chat SDK minified code included in it Chat SDK should be a dependency of UIKit Advantages: * Chat SDK bug fixes will be added for free * Eliminate the need for handlers --- So what was the issue: If you are usig rollup for bundling in config.external you have to be specific ie> This works: ``` external: [ '@sendbird/chat', '@sendbird/chat/groupChannel', '@sendbird/chat/openChannel', '@sendbird/chat/message', ] ``` This doesnt: ``` external: [ '@sendbird/chat', ] ``` fixes: https://sendbird.atlassian.net/browse/UIKIT-2274
1 parent 1bcbef9 commit 2b5f9c0

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

rollup.config.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,10 @@ module.exports = ({
3838
},
3939
],
4040
external: [
41-
// unbundled version of @sendbird/chat fails in production
42-
// '@sendbird/chat',
41+
'@sendbird/chat',
42+
'@sendbird/chat/groupChannel',
43+
'@sendbird/chat/openChannel',
44+
'@sendbird/chat/message',
4345
'react-dom/server',
4446
'prop-types',
4547
'react',

0 commit comments

Comments
 (0)