Bugfix: [v3] Fix to active disableAutoSelect props (#152)

Apply disableAutoSelect props in the channel list init step

Author: HoonBaek

src/smart-components/App/stories/index.stories.js

@@ -243,6 +243,7 @@ export const user2 = () => fitPageSize(
     config={{ logLevel: 'all', userMention: { maxMentionCount: 2, maxSuggestionCount: 5 } }}
     replyType="QUOTE_REPLY"
     useMessageGrouping={false}
+    disableAutoSelect
     imageCompression={{
       compressionRate: 0.5,
       resizingWidth: 100,

src/smart-components/ChannelList/context/ChannelListProvider.tsx

@@ -95,6 +95,7 @@ interface ChannelListStoreInterface {
   showSettings: boolean;
   channelListQuery: GroupChannelListQuery;
   currentUserId: string;
+  disableAutoSelect: boolean;
 }
 
 const ChannelListContext = React.createContext<ChannelListProviderInterface | null>({
@@ -176,13 +177,6 @@ const ChannelListProvider: React.FC<ChannelListProviderProps> = (props: ChannelL
     };
   }, [sdkIntialized]);
 
-  useEffect(() => {
-    channelListDispatcher({
-      type: channelListActions.SET_AUTO_SELECT_CHANNEL_ITEM,
-      payload: disableAutoSelect,
-    });
-  }, [disableAutoSelect]);
-
   useEffect(() => {
     setSdkChannelHandlerId(uuidv4);
     if (sdkIntialized) {

src/smart-components/ChannelList/dux/__tests__/reducers.spec.js

@@ -8,7 +8,7 @@ describe('Channels-Reducers', () => {
   it('should set channels on INIT_CHANNELS_SUCCESS', () => {
     const nextState = reducers(initialState, {
       type: actionTypes.INIT_CHANNELS_SUCCESS,
-      payload: mockData.allChannels,
+      payload: { channelList: mockData.allChannels },
     });
 
     expect(nextState.initialized).toEqual(true);

src/smart-components/ChannelList/dux/actionTypes.js

@@ -2,7 +2,6 @@ export const RESET_CHANNEL_LIST = 'RESET_CHANNEL_LIST';
 export const CREATE_CHANNEL = 'CREATE_CHANNEL';
 export const UNLOAD_CHANNELS = 'UNLOAD_CHANNELS';
 export const SET_CHANNEL_LOADING = 'SET_CHANNEL_LOADING';
-export const SET_AUTO_SELECT_CHANNEL_ITEM = 'SET_AUTO_SELECT_CHANNEL_ITEM';
 export const LEAVE_CHANNEL_SUCCESS = 'LEAVE_CHANNEL_SUCCESS';
 
 export const SET_CURRENT_CHANNEL = 'SET_CURRENT_CHANNEL';

src/smart-components/ChannelList/dux/reducers.js

@@ -11,21 +11,24 @@ export default function reducer(state, action) {
       };
     case actions.RESET_CHANNEL_LIST:
       return initialState;
-    case actions.INIT_CHANNELS_SUCCESS:
+    case actions.INIT_CHANNELS_SUCCESS: {
+      const { channelList, disableAutoSelect } = action.payload;
       return {
         ...state,
         initialized: true,
         loading: false,
-        allChannels: action.payload,
+        allChannels: channelList,
+        disableAutoSelect,
         currentChannel: (
-          !state.disableAutoSelect
-          && action.payload
-          && action.payload.length
-          && action.payload.length > 0
+          !disableAutoSelect
+          && channelList
+          && channelList.length
+          && channelList.length > 0
         )
-          ? action.payload[0]
+          ? channelList[0]
           : null,
       };
+    }
     case actions.FETCH_CHANNELS_SUCCESS: {
       const currentChannels = state.allChannels.map((c) => c.url);
       const filteredChannels = action.payload.filter(
@@ -265,12 +268,6 @@ export default function reducer(state, action) {
         currentUserId: action.payload.currentUserId,
         channelListQuery: action.payload.channelListQuery,
       };
-    case actions.SET_AUTO_SELECT_CHANNEL_ITEM: {
-      return {
-        ...state,
-        ableAutoSelect: action.payload,
-      };
-    }
     default:
       return state;
   }

src/smart-components/ChannelList/utils.js

@@ -217,7 +217,7 @@ function setupChannelList({
       }
       channelListDispatcher({
         type: channelActions.INIT_CHANNELS_SUCCESS,
-        payload: sortedChannelList,
+        payload: { channelList: sortedChannelList, disableAutoSelect },
       });
       const canSetMarkAsDelivered = sdk?.appInfo?.premiumFeatureList
         ?.find((feature) => (feature === DELIVERY_RECIPT));