Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with v2 mongo driver #25

Open
bengourley opened this issue Jun 9, 2016 · 2 comments
Open

Doesn't work with v2 mongo driver #25

bengourley opened this issue Jun 9, 2016 · 2 comments

Comments

@bengourley
Copy link
Contributor

https://mongodb.github.io/node-mongodb-native/2.0/meta/changes-from-1.0/

The changes to the insert(), update() and remove() methods mean that it calls back with "mongodb-core" result object rather than the saved object.

@serby
Copy link
Owner

serby commented Jun 9, 2016

I was discussing the upgrade with @microadam recently.

I think it's going to need to be done as part of the v2 upgrade.

@bengourley
Copy link
Contributor Author

Also I'm wondering if you need to depend on the entire mongo driver at all in this module. SInce it only looks like you use it for ObjectID (and tests) you could npm i --save-dev mongodb and npm i --save objectid for a lighter install footprint.

As an aside, quite a lot has changed in the driver from v1 to v2. The method names are very clunky and it seems to be a less user friendly API in my opinion 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants