Skip to content

Support proxy configuration #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jux-stef wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Support proxy configuration #43

jux-stef wants to merge 4 commits into from

Conversation

@jux-stef
Copy link

@jux-stef jux-stef commented Jun 12, 2023 •
edited
Loading

  • Add proxy informations needed to SlackSinkOptions (address, username, password)
  • Update HttpClient creation (from SlackSink.cs) so it uses proxy
  • Update extensions methods
  • Update readme / version

Note :
If ProxyAddress is null the request works as before
This feature is .net standard 2.0+ compatible only (because of WebProxy class)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jux-stef