Unable to use variables for profile

[jamesstidard]

Issue description

Hi,

When looking for a way to account for people naming their aws profiles differently throughout our team, I think I've found a place where the variable substitution isn't behaving (or maybe it's just unsupported).

Passing --aws-profile xxx doesn't appear to override the profile if set in a stage. So I went to try and create that behaviour:

stages:
  alpha:
    resolvers:
      aws-account-dev:
        type: aws
        profile: ${opt:aws-profile, dev}
        region: eu-west-2

This errors with a json parsing error:

✖ SyntaxError: Unexpected token 'd', "dev" is not valid JSON
    at JSON.parse (<anonymous>)
    at parseLiteralValue (file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:6148)
    at extractPlaceholderDetailsFromPlaceholderString (file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:5910)
    at extract (file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:8393)
    at extractPlaceholdersFromString (file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:8690)
    at collectFromObject (file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:7372)
    at collectFromObject (file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:7567)
    at async collectFromObject (file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:7561)
    at async collectFromObject (file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:7561)
    at async collectFromObject (file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:7561)

Thanks for the framework, and any help.

Context

No response

[czubocha]

Hey @jamesstidard, can you try ${opt:aws-profile, 'dev'} (put dev in single quotes)?

[jamesstidard]

Still not behaving. Looks like I included the wrong stack trace with the initial report though, sorry (I must have got mixed around while I was trying variations).

Both single quote and double quotes actually returns:

✖ Error: Failed to resolve variable 'region' with resolver 'ssm' and provider 'aws-account-dev': Error: AWS credentials missing or invalid. Original error from AWS: Could not load credentials from any providers
    at #resolveKey (file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:25585)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async _ResolverManager.resolve (file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:31575)
    at async #handlePlaceholderNode (file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:30120)
    at async file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:27992
    at async processNodeAndHandleCompletion (file:///Users/james/.serverless/releases/4.20.2/package/dist/sf-core.js:711:16771)

[czubocha]

Hmm, okay, are you trying to resolve region from SSM using something like ${ssm:region} somewhere in the config file? If so, where?

[jamesstidard]

@czubocha no funny business with ssm, just using ${aws:region} dotted around.

I use in ${aws:region} provider:environment:REGION, and provider:iam:role:statements:Resource.

Thanks for the help. I'm just scanning my config file, as I can share it if it's not got anything sensitive in it. or I can make a minimal example.

[jamesstidard]

@czubocha made a minimal example, and it works. So there's something special about my config. I'll slowly add stuff and try and narrow down what's causing it. If I find out, and I still think it's a bug, then I'll reopen the ticket. Thanks for rubber ducking.

[czubocha]

Okay, you can always use ${AWS::Region} to have it resolved by CloudFormation at deployment time instead of during packaging if that’s causing issues - but feel free to reopen if you think it’s a bug 👍

[jamesstidard]

Here's a minimal example. It turns up if I try to both set the stages:<stage>:resolvers:<name>:profile using the the ${opt:} or ${env:}, while also using a ${aws:} in the stages:<stage>:resolvers:<name>:params. Independently, they both work.

org: myorg
service: foo

provider:
  name: aws
  runtime: nodejs20.x

functions:
  hello:
    handler: handler.hello
    events:
      - httpApi:
          path: /
          method: get

stages:
  alpha:
    resolvers:
      aws-account-dev:
        type: aws
        profile: ${env:AWS_DEV_PROFILE, 'dev'}  # <---- this 
        region: eu-west-2
        dashboard: false
    params:
      region: ${aws:region} # <---- combined with this

[czubocha]

Thanks. It looks like it's trying to resolve region: ${aws:region} before profile: ${env:AWS_DEV_PROFILE, 'dev'} is resolved. We’ll look into it.

[czubocha]

Hi @jamesstidard, we've released a fix in v4.21.1, so this should be resolved now. Please give it a try and let us know - thanks for reporting it and for providing the minimal example!

[jamesstidard]

@czubocha amazing. Thanks soo much. I'll give it a shot and shout if I have any issues. 🙌🙇‍♂️