Skip to content

Commit 2f842fe

Browse files
committed
chore: fix the assert unreachable equivalent
1 parent 1bfab13 commit 2f842fe

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

CMakeLists.txt

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,24 @@ endif()
4949

5050

5151
add_library(${PROJECT_NAME} SHARED ${SOURCE_FILES} ${CMAKE_JS_SRC})
52-
target_include_directories(${PROJECT_NAME} PRIVATE ${CMAKE_JS_INC} "include/" "${CMAKE_CURRENT_SOURCE_DIR}/node_modules/node-addon-api" "${CMAKE_CURRENT_SOURCE_DIR}/node_modules" "${CMAKE_CURRENT_SOURCE_DIR}/node_modules/node-api-headers/include")
52+
53+
# Mark the node-addon-api headers as system so the -Werror=switch-enum does not apply to them
54+
target_include_directories(${PROJECT_NAME}
55+
SYSTEM PRIVATE
56+
${CMAKE_JS_INC}
57+
${CMAKE_CURRENT_SOURCE_DIR}/node_modules/node-addon-api
58+
${CMAKE_CURRENT_SOURCE_DIR}/node_modules
59+
${CMAKE_CURRENT_SOURCE_DIR}/node_modules/node-api-headers/include
60+
)
61+
62+
target_include_directories(${PROJECT_NAME} PRIVATE "include/" )
5363

5464
set_target_properties(${PROJECT_NAME} PROPERTIES PREFIX "" SUFFIX ".node")
5565
target_link_libraries(${PROJECT_NAME} PRIVATE ${CMAKE_JS_LIB} ${LIBSESSION_STATIC_BUNDLE_LIBS})
5666

5767

5868
if(UNIX AND NOT APPLE)
59-
# Add switch-enum warnings as errors on Linux (see __builtin_unreachable()/UNREACHABLE() calls)
60-
# target_compile_options(${PROJECT_NAME} PRIVATE -Werror=switch-enum)
69+
target_compile_options(${PROJECT_NAME} PRIVATE -Werror=switch-enum)
6170
endif()
6271

6372

0 commit comments

Comments
 (0)