Skip to content

Commit d7d5162

Browse files
committed
Add test for invalid metric name
1 parent 7011380 commit d7d5162

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

modin/tests/test_metrics.py

+8
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
_metric_handlers,
2323
add_metric_handler,
2424
clear_metric_handler,
25+
emit_metric,
2526
)
2627

2728

@@ -85,6 +86,13 @@ def test_metrics_handler_fails(metric_client):
8586
assert len(metric_client._metrics) == 0
8687

8788

89+
def test_emit_name_enforced():
90+
try:
91+
emit_metric("Not::A::Valid::Metric::Name", 1.0)
92+
except KeyError:
93+
pass
94+
95+
8896
def test_metrics_can_be_opt_out(metric_client):
8997
# Can register a metrics handler if metrics are
9098
# disabled

0 commit comments

Comments
 (0)