-
Notifications
You must be signed in to change notification settings - Fork 202
Closed
Description
Context
This issue tracks follow-up work for newly added chains (HyperEVM/Plasma) based on testing feedback from shapeshift/hdwallet#756 (comment)
Testing Notes from PR #756
Working:
- Derivation works
- Swapping to HyperEVM works
- Swapping to ERC20 seems to be working but with issues
- Sending HYPE works
- Gas estimate seems to be fine
Issues Identified:
- ERC20 balances are not updated after a swap (might be fixed by rebasing on develop)
- No throttler but no rate limit noticed
- The multicall system doesn't work, need to take what was done with monad
- ERC20 balances don't seem to be fetched at start (might be the reason why they aren't updated after a swap)
- Couldn't test an ERC20 send as balance access is blocked
- Missing market-data
Action Items
-
Tackle all identified issues for newly added chains (hyperEVM/plasma)
- Fix ERC20 balance updates after swaps
- Implement multicall system (reference monad implementation)
- Fix ERC20 balance fetching at start
- Investigate and fix balance access issues
-
Revamp the chain skill with new bullet points and/or gotchas
- Document lessons learned from recent monad fixes
- Add integration gotchas for new EVM-compatible chains
- Update chain integration checklist/guidelines
Reference
Original PR: shapeshift/hdwallet#756
Requester: @gomesalexandre
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done