Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Biodiverse::GUIManager::do_trim_tree_to_basedata - speed up range search as per PE calcs #681

Open
shawnlaffan opened this issue Nov 26, 2017 · 0 comments
Open

Biodiverse::GUIManager::do_trim_tree_to_basedata - speed up range search as per PE calcs #681

shawnlaffan opened this issue Nov 26, 2017 · 0 comments
Assignees
@shawnlaffan
Labels
enhancement

Comments

@shawnlaffan
Copy link
Owner

The conversion of trees to use range weighted branches could do with some optimisation, as large trees can take longer than is ideal. Profiling suggests a few places to optimise, but the approaches used in the PE calcs will be a good place to start as they were optimised some time ago.
@shawnlaffan shawnlaffan self-assigned this Nov 26, 2017
@shawnlaffan shawnlaffan added this to the Release_2.1 milestone Nov 26, 2017
shawnlaffan added a commit that referenced this issue Nov 26, 2017
@shawnlaffan
Squeeze a (very) small amount of improved performance into the range …
1e09017 
…calculations

Use an array args variant of a sub

Updates #681
shawnlaffan added a commit that referenced this issue Dec 9, 2017
@shawnlaffan
Use named descendants
e2be192 
Uses cache

Updates #681
shawnlaffan added a commit that referenced this issue Dec 9, 2017
@shawnlaffan
Delete the cache after we've used it, not during its use
d2bd9c9 
Updates #681
shawnlaffan added a commit that referenced this issue Feb 24, 2018
@shawnlaffan
Use a sorted array to avoid repeated sorting
39c1aed 
Updates #681
shawnlaffan added a commit that referenced this issue Feb 24, 2018
@shawnlaffan
remove some old debugging code
11a5bb8 
Gives a slightly shorter and neater sub.

Updates #681
shawnlaffan added a commit that referenced this issue Feb 24, 2018
@shawnlaffan
Avoid the need for a copied hash
25d678b 
It was only used to check deletions, so we can build one as we go instead.
Copying the original hash was a substantial part of the run time under profiling.

Also clear up some commentary.

Updates #681
@shawnlaffan shawnlaffan modified the milestones: Release_2.1, Release_3 Aug 11, 2018
@shawnlaffan shawnlaffan removed this from the Release_3 milestone Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnlaffan shawnlaffan

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shawnlaffan