Skip to content

Commit cb787f4

Browse files
Al Virotorvalds
Al Viro
authored andcommitted
[tree-wide] finally take no_llseek out
no_llseek had been defined to NULL two years ago, in commit 868941b ("fs: remove no_llseek") To quote that commit, At -rc1 we'll need do a mechanical removal of no_llseek - git grep -l -w no_llseek | grep -v porting.rst | while read i; do sed -i '/\<no_llseek\>/d' $i done would do it. Unfortunately, that hadn't been done. Linus, could you do that now, so that we could finally put that thing to rest? All instances are of the form .llseek = no_llseek, so it's obviously safe. Signed-off-by: Al Viro <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 075dbe9 commit cb787f4

File tree

221 files changed

+0
-270
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

221 files changed

+0
-270
lines changed

Documentation/watchdog/convert_drivers_to_kernel_api.rst

-1

arch/parisc/kernel/perf.c

-1
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,6 @@ static long perf_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
466466
}
467467

468468
static const struct file_operations perf_fops = {
469-
.llseek = no_llseek,
470469
.read = perf_read,
471470
.write = perf_write,
472471
.unlocked_ioctl = perf_ioctl,

arch/s390/hypfs/hypfs_dbfs.c

-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ static long dbfs_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
7676

7777
static const struct file_operations dbfs_ops = {
7878
.read = dbfs_read,
79-
.llseek = no_llseek,
8079
.unlocked_ioctl = dbfs_ioctl,
8180
};
8281

arch/s390/hypfs/inode.c

-1
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,6 @@ static const struct file_operations hypfs_file_ops = {
443443
.release = hypfs_release,
444444
.read_iter = hypfs_read_iter,
445445
.write_iter = hypfs_write_iter,
446-
.llseek = no_llseek,
447446
};
448447

449448
static struct file_system_type hypfs_type = {

arch/s390/kernel/debug.c

-1
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ static const struct file_operations debug_file_ops = {
163163
.write = debug_input,
164164
.open = debug_open,
165165
.release = debug_close,
166-
.llseek = no_llseek,
167166
};
168167

169168
static struct dentry *debug_debugfs_root_entry;

arch/s390/kernel/perf_cpum_cf.c

-1
Original file line numberDiff line numberDiff line change
@@ -1698,7 +1698,6 @@ static const struct file_operations cfset_fops = {
16981698
.release = cfset_release,
16991699
.unlocked_ioctl = cfset_ioctl,
17001700
.compat_ioctl = cfset_ioctl,
1701-
.llseek = no_llseek
17021701
};
17031702

17041703
static struct miscdevice cfset_dev = {

arch/s390/kernel/sysinfo.c

-1
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,6 @@ static const struct file_operations stsi_##fc##_##s1##_##s2##_fs_ops = { \
498498
.open = stsi_open_##fc##_##s1##_##s2, \
499499
.release = stsi_release, \
500500
.read = stsi_read, \
501-
.llseek = no_llseek, \
502501
};
503502

504503
static int stsi_release(struct inode *inode, struct file *file)

arch/s390/pci/pci_clp.c

-1
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,6 @@ static const struct file_operations clp_misc_fops = {
657657
.release = clp_misc_release,
658658
.unlocked_ioctl = clp_misc_ioctl,
659659
.compat_ioctl = clp_misc_ioctl,
660-
.llseek = no_llseek,
661660
};
662661

663662
static struct miscdevice clp_misc_device = {

arch/um/drivers/harddog_kern.c

-1
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ static const struct file_operations harddog_fops = {
164164
.compat_ioctl = compat_ptr_ioctl,
165165
.open = harddog_open,
166166
.release = harddog_release,
167-
.llseek = no_llseek,
168167
};
169168

170169
static struct miscdevice harddog_miscdev = {

arch/um/drivers/hostaudio_kern.c

-2
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,6 @@ static int hostmixer_release(struct inode *inode, struct file *file)
291291

292292
static const struct file_operations hostaudio_fops = {
293293
.owner = THIS_MODULE,
294-
.llseek = no_llseek,
295294
.read = hostaudio_read,
296295
.write = hostaudio_write,
297296
.poll = hostaudio_poll,
@@ -304,7 +303,6 @@ static const struct file_operations hostaudio_fops = {
304303

305304
static const struct file_operations hostmixer_fops = {
306305
.owner = THIS_MODULE,
307-
.llseek = no_llseek,
308306
.unlocked_ioctl = hostmixer_ioctl_mixdev,
309307
.open = hostmixer_open_mixdev,
310308
.release = hostmixer_release,

arch/x86/kernel/cpu/mce/dev-mcelog.c

-1
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,6 @@ static const struct file_operations mce_chrdev_ops = {
331331
.poll = mce_chrdev_poll,
332332
.unlocked_ioctl = mce_chrdev_ioctl,
333333
.compat_ioctl = compat_ptr_ioctl,
334-
.llseek = no_llseek,
335334
};
336335

337336
static struct miscdevice mce_chrdev_device = {

arch/x86/kernel/cpu/resctrl/pseudo_lock.c

-1
Original file line numberDiff line numberDiff line change
@@ -1567,7 +1567,6 @@ static int pseudo_lock_dev_mmap(struct file *filp, struct vm_area_struct *vma)
15671567

15681568
static const struct file_operations pseudo_lock_dev_fops = {
15691569
.owner = THIS_MODULE,
1570-
.llseek = no_llseek,
15711570
.read = NULL,
15721571
.write = NULL,
15731572
.open = pseudo_lock_dev_open,

drivers/acpi/apei/erst-dbg.c

-1
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,6 @@ static const struct file_operations erst_dbg_ops = {
199199
.read = erst_dbg_read,
200200
.write = erst_dbg_write,
201201
.unlocked_ioctl = erst_dbg_ioctl,
202-
.llseek = no_llseek,
203202
};
204203

205204
static struct miscdevice erst_dbg_dev = {

drivers/auxdisplay/charlcd.c

-1
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,6 @@ static const struct file_operations charlcd_fops = {
526526
.write = charlcd_write,
527527
.open = charlcd_open,
528528
.release = charlcd_release,
529-
.llseek = no_llseek,
530529
};
531530

532531
static struct miscdevice charlcd_dev = {

drivers/block/mtip32xx/mtip32xx.c

-2
Original file line numberDiff line numberDiff line change
@@ -2259,14 +2259,12 @@ static const struct file_operations mtip_regs_fops = {
22592259
.owner = THIS_MODULE,
22602260
.open = simple_open,
22612261
.read = mtip_hw_read_registers,
2262-
.llseek = no_llseek,
22632262
};
22642263

22652264
static const struct file_operations mtip_flags_fops = {
22662265
.owner = THIS_MODULE,
22672266
.open = simple_open,
22682267
.read = mtip_hw_read_flags,
2269-
.llseek = no_llseek,
22702268
};
22712269

22722270
static void mtip_hw_debugfs_init(struct driver_data *dd)

drivers/block/pktcdvd.c

-1
Original file line numberDiff line numberDiff line change
@@ -2835,7 +2835,6 @@ static const struct file_operations pkt_ctl_fops = {
28352835
.compat_ioctl = pkt_ctl_compat_ioctl,
28362836
#endif
28372837
.owner = THIS_MODULE,
2838-
.llseek = no_llseek,
28392838
};
28402839

28412840
static struct miscdevice pkt_misc = {

drivers/block/ublk_drv.c

-1
Original file line numberDiff line numberDiff line change
@@ -1983,7 +1983,6 @@ static const struct file_operations ublk_ch_fops = {
19831983
.owner = THIS_MODULE,
19841984
.open = ublk_ch_open,
19851985
.release = ublk_ch_release,
1986-
.llseek = no_llseek,
19871986
.read_iter = ublk_ch_read_iter,
19881987
.write_iter = ublk_ch_write_iter,
19891988
.uring_cmd = ublk_ch_uring_cmd,

drivers/bluetooth/hci_vhci.c

-1
Original file line numberDiff line numberDiff line change
@@ -679,7 +679,6 @@ static const struct file_operations vhci_fops = {
679679
.poll = vhci_poll,
680680
.open = vhci_open,
681681
.release = vhci_release,
682-
.llseek = no_llseek,
683682
};
684683

685684
static struct miscdevice vhci_miscdev = {

drivers/bus/moxtet.c

-2
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,6 @@ static const struct file_operations input_fops = {
484484
.owner = THIS_MODULE,
485485
.open = moxtet_debug_open,
486486
.read = input_read,
487-
.llseek = no_llseek,
488487
};
489488

490489
static ssize_t output_read(struct file *file, char __user *buf, size_t len,
@@ -549,7 +548,6 @@ static const struct file_operations output_fops = {
549548
.open = moxtet_debug_open,
550549
.read = output_read,
551550
.write = output_write,
552-
.llseek = no_llseek,
553551
};
554552

555553
static int moxtet_register_debugfs(struct moxtet *moxtet)

drivers/char/applicom.c

-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ static irqreturn_t ac_interrupt(int, void *);
111111

112112
static const struct file_operations ac_fops = {
113113
.owner = THIS_MODULE,
114-
.llseek = no_llseek,
115114
.read = ac_read,
116115
.write = ac_write,
117116
.unlocked_ioctl = ac_ioctl,

drivers/char/ds1620.c

-1
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,6 @@ static const struct file_operations ds1620_fops = {
353353
.open = ds1620_open,
354354
.read = ds1620_read,
355355
.unlocked_ioctl = ds1620_unlocked_ioctl,
356-
.llseek = no_llseek,
357356
};
358357

359358
static struct miscdevice ds1620_miscdev = {

drivers/char/dtlk.c

-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ static const struct file_operations dtlk_fops =
107107
.unlocked_ioctl = dtlk_ioctl,
108108
.open = dtlk_open,
109109
.release = dtlk_release,
110-
.llseek = no_llseek,
111110
};
112111

113112
/* local prototypes */

drivers/char/hpet.c

-1
Original file line numberDiff line numberDiff line change
@@ -700,7 +700,6 @@ hpet_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
700700

701701
static const struct file_operations hpet_fops = {
702702
.owner = THIS_MODULE,
703-
.llseek = no_llseek,
704703
.read = hpet_read,
705704
.poll = hpet_poll,
706705
.unlocked_ioctl = hpet_ioctl,

drivers/char/ipmi/ipmi_watchdog.c

-1
Original file line numberDiff line numberDiff line change
@@ -903,7 +903,6 @@ static const struct file_operations ipmi_wdog_fops = {
903903
.open = ipmi_open,
904904
.release = ipmi_close,
905905
.fasync = ipmi_fasync,
906-
.llseek = no_llseek,
907906
};
908907

909908
static struct miscdevice ipmi_wdog_miscdev = {

drivers/char/pc8736x_gpio.c

-1
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,6 @@ static const struct file_operations pc8736x_gpio_fileops = {
235235
.open = pc8736x_gpio_open,
236236
.write = nsc_gpio_write,
237237
.read = nsc_gpio_read,
238-
.llseek = no_llseek,
239238
};
240239

241240
static void __init pc8736x_init_shadow(void)

drivers/char/ppdev.c

-1
Original file line numberDiff line numberDiff line change
@@ -786,7 +786,6 @@ static const struct class ppdev_class = {
786786

787787
static const struct file_operations pp_fops = {
788788
.owner = THIS_MODULE,
789-
.llseek = no_llseek,
790789
.read = pp_read,
791790
.write = pp_write,
792791
.poll = pp_poll,

drivers/char/scx200_gpio.c

-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ static const struct file_operations scx200_gpio_fileops = {
6868
.read = nsc_gpio_read,
6969
.open = scx200_gpio_open,
7070
.release = scx200_gpio_release,
71-
.llseek = no_llseek,
7271
};
7372

7473
static struct cdev scx200_gpio_cdev; /* use 1 cdev for all pins */

drivers/char/sonypi.c

-1
Original file line numberDiff line numberDiff line change
@@ -1054,7 +1054,6 @@ static const struct file_operations sonypi_misc_fops = {
10541054
.release = sonypi_misc_release,
10551055
.fasync = sonypi_misc_fasync,
10561056
.unlocked_ioctl = sonypi_misc_ioctl,
1057-
.llseek = no_llseek,
10581057
};
10591058

10601059
static struct miscdevice sonypi_misc_device = {

drivers/char/tpm/tpm-dev.c

-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ static int tpm_release(struct inode *inode, struct file *file)
5959

6060
const struct file_operations tpm_fops = {
6161
.owner = THIS_MODULE,
62-
.llseek = no_llseek,
6362
.open = tpm_open,
6463
.read = tpm_common_read,
6564
.write = tpm_common_write,

drivers/char/tpm/tpm_vtpm_proxy.c

-1
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,6 @@ static int vtpm_proxy_fops_release(struct inode *inode, struct file *filp)
243243

244244
static const struct file_operations vtpm_proxy_fops = {
245245
.owner = THIS_MODULE,
246-
.llseek = no_llseek,
247246
.read = vtpm_proxy_fops_read,
248247
.write = vtpm_proxy_fops_write,
249248
.poll = vtpm_proxy_fops_poll,

drivers/char/tpm/tpmrm-dev.c

-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ static int tpmrm_release(struct inode *inode, struct file *file)
4646

4747
const struct file_operations tpmrm_fops = {
4848
.owner = THIS_MODULE,
49-
.llseek = no_llseek,
5049
.open = tpmrm_open,
5150
.read = tpm_common_read,
5251
.write = tpm_common_write,

drivers/char/virtio_console.c

-1
Original file line numberDiff line numberDiff line change
@@ -1093,7 +1093,6 @@ static const struct file_operations port_fops = {
10931093
.poll = port_fops_poll,
10941094
.release = port_fops_release,
10951095
.fasync = port_fops_fasync,
1096-
.llseek = no_llseek,
10971096
};
10981097

10991098
/*

drivers/counter/counter-chrdev.c

-1
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,6 @@ static int counter_chrdev_release(struct inode *inode, struct file *filp)
454454

455455
static const struct file_operations counter_fops = {
456456
.owner = THIS_MODULE,
457-
.llseek = no_llseek,
458457
.read = counter_chrdev_read,
459458
.poll = counter_chrdev_poll,
460459
.unlocked_ioctl = counter_chrdev_ioctl,

drivers/firewire/core-cdev.c

-1
Original file line numberDiff line numberDiff line change
@@ -1911,7 +1911,6 @@ static __poll_t fw_device_op_poll(struct file *file, poll_table * pt)
19111911

19121912
const struct file_operations fw_device_ops = {
19131913
.owner = THIS_MODULE,
1914-
.llseek = no_llseek,
19151914
.open = fw_device_op_open,
19161915
.read = fw_device_op_read,
19171916
.unlocked_ioctl = fw_device_op_ioctl,

drivers/firmware/arm_scmi/driver.c

-1
Original file line numberDiff line numberDiff line change
@@ -2886,7 +2886,6 @@ static ssize_t reset_all_on_write(struct file *filp, const char __user *buf,
28862886
static const struct file_operations fops_reset_counts = {
28872887
.owner = THIS_MODULE,
28882888
.open = simple_open,
2889-
.llseek = no_llseek,
28902889
.write = reset_all_on_write,
28912890
};
28922891

drivers/firmware/arm_scmi/raw_mode.c

-5
Original file line numberDiff line numberDiff line change
@@ -950,7 +950,6 @@ static const struct file_operations scmi_dbg_raw_mode_reset_fops = {
950950
.open = scmi_dbg_raw_mode_open,
951951
.release = scmi_dbg_raw_mode_release,
952952
.write = scmi_dbg_raw_mode_reset_write,
953-
.llseek = no_llseek,
954953
.owner = THIS_MODULE,
955954
};
956955

@@ -960,7 +959,6 @@ static const struct file_operations scmi_dbg_raw_mode_message_fops = {
960959
.read = scmi_dbg_raw_mode_message_read,
961960
.write = scmi_dbg_raw_mode_message_write,
962961
.poll = scmi_dbg_raw_mode_message_poll,
963-
.llseek = no_llseek,
964962
.owner = THIS_MODULE,
965963
};
966964

@@ -977,7 +975,6 @@ static const struct file_operations scmi_dbg_raw_mode_message_async_fops = {
977975
.read = scmi_dbg_raw_mode_message_read,
978976
.write = scmi_dbg_raw_mode_message_async_write,
979977
.poll = scmi_dbg_raw_mode_message_poll,
980-
.llseek = no_llseek,
981978
.owner = THIS_MODULE,
982979
};
983980

@@ -1001,7 +998,6 @@ static const struct file_operations scmi_dbg_raw_mode_notification_fops = {
1001998
.release = scmi_dbg_raw_mode_release,
1002999
.read = scmi_test_dbg_raw_mode_notif_read,
10031000
.poll = scmi_test_dbg_raw_mode_notif_poll,
1004-
.llseek = no_llseek,
10051001
.owner = THIS_MODULE,
10061002
};
10071003

@@ -1025,7 +1021,6 @@ static const struct file_operations scmi_dbg_raw_mode_errors_fops = {
10251021
.release = scmi_dbg_raw_mode_release,
10261022
.read = scmi_test_dbg_raw_mode_errors_read,
10271023
.poll = scmi_test_dbg_raw_mode_errors_poll,
1028-
.llseek = no_llseek,
10291024
.owner = THIS_MODULE,
10301025
};
10311026

drivers/firmware/efi/capsule-loader.c

-1
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,6 @@ static const struct file_operations efi_capsule_fops = {
309309
.open = efi_capsule_open,
310310
.write = efi_capsule_write,
311311
.release = efi_capsule_release,
312-
.llseek = no_llseek,
313312
};
314313

315314
static struct miscdevice efi_capsule_misc = {

drivers/firmware/efi/test/efi_test.c

-1
Original file line numberDiff line numberDiff line change
@@ -750,7 +750,6 @@ static const struct file_operations efi_test_fops = {
750750
.unlocked_ioctl = efi_test_ioctl,
751751
.open = efi_test_open,
752752
.release = efi_test_close,
753-
.llseek = no_llseek,
754753
};
755754

756755
static struct miscdevice efi_test_dev = {

drivers/firmware/turris-mox-rwtm.c

-1
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,6 @@ static const struct file_operations do_sign_fops = {
386386
.open = rwtm_debug_open,
387387
.read = do_sign_read,
388388
.write = do_sign_write,
389-
.llseek = no_llseek,
390389
};
391390

392391
static void rwtm_debugfs_release(void *root)

drivers/gnss/core.c

-1
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,6 @@ static const struct file_operations gnss_fops = {
206206
.read = gnss_read,
207207
.write = gnss_write,
208208
.poll = gnss_poll,
209-
.llseek = no_llseek,
210209
};
211210

212211
static struct class *gnss_class;

drivers/gpio/gpio-mockup.c

-1
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,6 @@ static const struct file_operations gpio_mockup_debugfs_ops = {
347347
.open = gpio_mockup_debugfs_open,
348348
.read = gpio_mockup_debugfs_read,
349349
.write = gpio_mockup_debugfs_write,
350-
.llseek = no_llseek,
351350
.release = single_release,
352351
};
353352

drivers/gpio/gpio-sloppy-logic-analyzer.c

-1
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,6 @@ static const struct file_operations fops_trigger = {
217217
.owner = THIS_MODULE,
218218
.open = trigger_open,
219219
.write = trigger_write,
220-
.llseek = no_llseek,
221220
.release = single_release,
222221
};
223222

drivers/gpio/gpiolib-cdev.c

-1
Original file line numberDiff line numberDiff line change
@@ -2842,7 +2842,6 @@ static const struct file_operations gpio_fileops = {
28422842
.poll = lineinfo_watch_poll,
28432843
.read = lineinfo_watch_read,
28442844
.owner = THIS_MODULE,
2845-
.llseek = no_llseek,
28462845
.unlocked_ioctl = gpio_ioctl,
28472846
#ifdef CONFIG_COMPAT
28482847
.compat_ioctl = gpio_ioctl_compat,

0 commit comments

Comments
 (0)