Skip to content

Commit e3cbcf2

Browse files
committed
Add and edit TODO comments
1 parent 58cfa35 commit e3cbcf2

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

soql/parser/postprocess/normalize2.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ func (ctx *normalizeQueryContext) addUnselectedConditionalFields(
5656
switch conditions[i].Value.Type {
5757
case SoqlFieldInfo_Field:
5858
if _, ok := fieldMap[key]; !ok {
59-
// TODO: check it is co-related (field in the ancestor object); siblings are error
59+
// TODO: ~~check it is co-related (field in the ancestor object); siblings are error~~
6060
f := conditions[i].Value
6161
fieldMap[key] = f.Name
6262
f.NotSelected = true

soql/parser/postprocess/normalize3.go

+2
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ func (ctx *normalizeQueryContext) applyColIndexToFields(q *SoqlQuery, fields []S
3838
q.Parent.Fields = append(q.Parent.Fields, fields[i])
3939
q.Parent.From[j].PerObjectQuery.Fields = append(q.Parent.From[j].PerObjectQuery.Fields, fields[i])
4040

41+
// TODO: Delete fields[i] and shift the following?
42+
4143
isSet = true
4244
break
4345
}

soql/parser/postprocess/normalizeperobj.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ CHECK_FIELDS:
8888
}
8989
}
9090
if !hasConditionsOriginally {
91-
// TODO:
91+
// TODO: More conditions?
9292
innerJoined = true
9393
}
9494

0 commit comments

Comments
 (0)