Skip to content

Commit 9738b5e

Browse files
fix for #41
Co-Authored-By: Vo Luu Tuong Anh <[email protected]>
1 parent 56fe505 commit 9738b5e

File tree

10 files changed

+9
-20
lines changed

10 files changed

+9
-20
lines changed

jcppkernel/code_processing.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,15 @@
33
from .external_header import CPPExternalHeader
44

55
class CPPCodeProcessingUnit:
6-
76
main_head = 'int main() {'
87
main_foot = '\treturn 0;\n}'
98
comments = r'\/\/.*?(?=\r?\n)|\/\*[\s\S]*?\*\/'
109
main_method = r'\bmain\s*\(|^\s*#\s*define\s+\w+\s+main\b'
11-
12-
def _prep_main_function(self, code):
13-
code = f"{self.main_head}\n{code}\n{self.main_foot}"
14-
return code
1510

1611
def _add_code_compat(self, code, cpp_res_path):
1712
code = code_sub(self.comments, r'', code)
1813
if not code_search(self.main_method, code):
19-
code = self._prep_main_function(code)
14+
code = f"{self.main_head}\n{code}\n{self.main_foot}"
2015

2116
code = f"#include {cpp_res_path}\n{code}"
2217
code = CPPExternalHeader._support_external_header(CPPExternalHeader, code)

jcppkernel/external_header.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,19 @@
33

44
class CPPExternalHeader:
55
def _find_local_header(self):
6-
if hasattr(self, "_cached_local_header"):
7-
return self._cached_local_header
86
search_paths = [path.abspath(path.dirname(__file__)), prefix]
97
for base in search_paths:
108
current = base
119
while current != path.sep:
1210
cpp_header_path = path.join(current, "share", "cpp_header")
1311
if path.exists(path.join(cpp_header_path, "check_cpp.hpp")):
14-
self._cached_local_header = cpp_header_path
1512
return cpp_header_path
1613
new_current = path.dirname(current)
1714
if new_current == current:
1815
break
1916
current = new_current
20-
self._cached_local_header = ""
2117
return ""
22-
18+
2319
def _support_external_header(self, code):
2420
DATA_FILES_PATH = self._find_local_header(self)
2521
includes = []

jcppkernel/temp_file_processing.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,10 @@
22
from tempfile import NamedTemporaryFile
33

44
class CPPTempFileProcessing:
5-
65
def _new_temp_file(self, files, **kwargs):
76
file = NamedTemporaryFile(delete=False, mode="w", **kwargs)
87
files.append(file.name)
98
return file
10-
119

1210
def _cleanup_files(self, master_path, files):
1311
for file in files:

jupyter-cpp-kernel-03/kernel_spec/kernel.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"-m",
55
"jupyter-cpp-kernel-03",
66
"-f",
7-
"{connection_file}"
7+
"\"{connection_file}\""
88
],
99
"display_name": "C++ 03",
1010
"language": "c++"

jupyter-cpp-kernel-11/kernel_spec/kernel.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"-m",
55
"jupyter-cpp-kernel-11",
66
"-f",
7-
"{connection_file}"
7+
"\"{connection_file}\""
88
],
99
"display_name": "C++ 11",
1010
"language": "c++"

jupyter-cpp-kernel-14/kernel_spec/kernel.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"-m",
55
"jupyter-cpp-kernel-14",
66
"-f",
7-
"{connection_file}"
7+
"\"{connection_file}\""
88
],
99
"display_name": "C++ 14",
1010
"language": "c++"

jupyter-cpp-kernel-17/kernel_spec/kernel.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"-m",
55
"jupyter-cpp-kernel-17",
66
"-f",
7-
"{connection_file}"
7+
"\"{connection_file}\""
88
],
99
"display_name": "C++ 17",
1010
"language": "c++"

jupyter-cpp-kernel-20/kernel_spec/kernel.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"-m",
55
"jupyter-cpp-kernel-20",
66
"-f",
7-
"{connection_file}"
7+
"\"{connection_file}\""
88
],
99
"display_name": "C++ 20",
1010
"language": "c++"

jupyter-cpp-kernel-23/kernel_spec/kernel.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"-m",
55
"jupyter-cpp-kernel-23",
66
"-f",
7-
"{connection_file}"
7+
"\"{connection_file}\""
88
],
99
"display_name": "C++ 23",
1010
"language": "c++"

jupyter-cpp-kernel-98/kernel_spec/kernel.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"-m",
55
"jupyter-cpp-kernel-98",
66
"-f",
7-
"{connection_file}"
7+
"\"{connection_file}\""
88
],
99
"display_name": "C++ 98",
1010
"language": "c++"

0 commit comments

Comments
 (0)