Skip to content

Debug instance controller wants to delete deleted pod #116

@TrayserCassa

Description

@TrayserCassa

Steps to reproduce

Check logs in datadog

What should happened?

No need for logging a error when the outcome is the wanted one. So check if the pod is there and log a warning if this is fine but unclear.

Or fix the underlying issue. Should check if the pod is also the correct one to be deleted.

What actually happened?

pods \"debug-42d915e6-909d-4c93-a54c-47ea12c4f582\" not found

Relevant log output

"host": "ip-10-14-40-185.eu-central-1.compute.internal-raven",
		"service": "operator",
		"message": "failed to delete pod",
		"attributes": {
			"request": {
				"name": "debug-42d915e6-909d-4c93-a54c-47ea12c4f582",
				"namespace": "magischdev-068bfc8f-1fb7-4d04-a070-e40648ee78a6"
			},
			"controller": "storedebuginstance",
			"level": "error",
			"logger": "storedebuginstance",
			"reconcileID": "ad13485e-f531-40c9-88dc-347a44422307",
			"error": "pods \"debug-42d915e6-909d-4c93-a54c-47ea12c4f582\" not found",
			"caller": "controller/storedebuginstance_controller.go:97",
			"StoreDebugInstance": {
				"name": "debug-42d915e6-909d-4c93-a54c-47ea12c4f582",
				"namespace": "magischdev-068bfc8f-1fb7-4d04-a070-e40648ee78a6"
			},
			"stacktrace": "github.com/shopware/shopware-operator/internal/controller.(*StoreDebugInstanceReconciler).Reconcile\n\t/home/runner/_work/shopware-operator/shopware-operator/internal/controller/storedebuginstance_controller.go:97\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Reconcile\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.3/pkg/internal/controller/controller.go:118\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.3/pkg/internal/controller/controller.go:328\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.3/pkg/internal/controller/controller.go:288\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.20.3/pkg/internal/controller/controller.go:249",
			"namespace": "magischdev-068bfc8f-1fb7-4d04-a070-e40648ee78a6",
			"name": "debug-42d915e6-909d-4c93-a54c-47ea12c4f582",
			"controllerGroup": "shop.shopware.com",
			"controllerKind": "StoreDebugInstance",
			"ts": 1750805069.2551925
		}
	}
}

Image

DOD

  • Make logger work with warning (Check fastly operator for that)
  • Fix the double delete request if this is the issue
  • Use a warning on the log error because this is something which is unexpected but ok to continue to run

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions