Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autosave by default #22

Open
shpaass opened this issue Feb 8, 2024 · 3 comments · May be fixed by #412
Open

Autosave by default #22

shpaass opened this issue Feb 8, 2024 · 3 comments · May be fixed by #412
Assignees
@shihan42

Comments

@shpaass
Copy link
Owner

shpaass commented Feb 8, 2024

When you close YAFC, it asks to confirm if you want to save the changes before closing.
I think we want to save changes in the overwhelming majority of cases, so it would be good to make it a toggled setting and set it to save without prompting by default.
@shihan42
Copy link
Collaborator

That's a neat idea!
Should it autosave every n seconds/minutes or after certain actions?

My personal preference would be after recipe changes, e.g. add/remove, alter quantities, etc.

@shpaass
Copy link
Owner Author

shpaass commented Feb 12, 2024

My personal preference would be after recipe changes, e.g. add/remove, alter quantities, etc.

If the save process doesn't lag the UI and doesn't write a lot, then I'm all for it.

@shihan42
Copy link
Collaborator

Yeah, I'll give it a try. Shouldn't be that bad.
Hooray for async I/O 👍

@shihan42 shihan42 mentioned this issue Feb 16, 2024
Draft
@shihan42 shihan42 self-assigned this Feb 27, 2024
This was referenced Feb 11, 2025
Merged
Open
@shpaass shpaass linked a pull request Feb 11, 2025 that will close this issue
Auto saving #412
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shihan42 shihan42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Auto saving MartijnvAdrichem/yafc-ce
2 participants
@shihan42 @shpaass