address comments

Author: shujingyang-db

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala

@@ -995,7 +995,7 @@ case class ShufflePartitionIdPassThroughSpec(
       // as the partitioning expression, we check compatibility as follows:
       // 1. Same number of clustering expressions
       // 2. Same number of partitions
-      // 3. each pair of partitioning expression from both sides has overlapping positions in their
+      // 3. each partitioning expression from both sides has overlapping positions in their
       //    corresponding distributions.
       distribution.clustering.length == otherDistribution.clustering.length &&
       partitioning.numPartitions == otherPartitioning.numPartitions && {

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ShuffleSpecSuite.scala

@@ -523,7 +523,6 @@ class ShuffleSpecSuite extends SparkFunSuite with SQLHelper {
 
   test("compatibility: ShufflePartitionIdPassThroughSpec vs other specs") {
     val dist = ClusteredDistribution(Seq($"a", $"b"))
-    val p = ShufflePartitionIdPassThrough(DirectShufflePartitionID($"a"), 10)
 
     // Compatibility with SinglePartitionShuffleSpec when numPartitions is 1
     val p1 = ShufflePartitionIdPassThrough(DirectShufflePartitionID($"a"), 1)
@@ -543,7 +542,7 @@ class ShuffleSpecSuite extends SparkFunSuite with SQLHelper {
     // Incompatible with HashShuffleSpec
     val p2 = HashPartitioning(Seq($"c"), 10)
     checkCompatible(
-      p.createShuffleSpec(dist),
+      ShufflePartitionIdPassThrough(DirectShufflePartitionID($"a"), 10).createShuffleSpec(dist),
       p2.createShuffleSpec(ClusteredDistribution(Seq($"c", $"d"))),
       expected = false
     )