adjust key refreshing

Author: keithsue

api/side/tss/tss.pulsar.go

@@ -130,8 +130,8 @@ message RefreshingRequest {
   uint64 dkg_id = 2;
   // removed participant set
   repeated string removed_participants = 3;
-  // new participant set
-  repeated string new_participants = 4;
+  // new threshold
+  uint32 threshold = 4;
   // expiration time
   google.protobuf.Timestamp expiration_time = 5 [(gogoproto.stdtime) = true, (gogoproto.nullable) = false];
   // status

api/side/tss/tx.pulsar.go

@@ -72,9 +72,9 @@ message MsgRefresh {
   repeated uint64 dkg_ids = 2;
   // removed participant set
   repeated string removed_participants = 3;
-  // new participant set
-  repeated string new_participants = 4;
-  // timeout duration
+  // new threshold set corresponding to the DKGs
+  repeated uint32 thresholds = 4;
+  // timeout duration per DKG refreshing
   google.protobuf.Duration timeout_duration = 5 [(gogoproto.nullable) = false, (gogoproto.stdduration) = true];
 }
 

docs/static/openapi.yml

@@ -88,23 +88,32 @@ func (m msgServer) Refresh(goCtx context.Context, msg *types.MsgRefresh) (*types
 
 	ctx := sdk.UnwrapSDKContext(goCtx)
 
-	for _, dkgId := range msg.DkgIds {
+	for i, dkgId := range msg.DkgIds {
 		if !m.HasDKGRequest(ctx, dkgId) {
-			return nil, errorsmod.Wrapf(types.ErrDKGRequestDoesNotExist, "%d", dkgId)
+			return nil, errorsmod.Wrapf(types.ErrDKGRequestDoesNotExist, "dkg %d", dkgId)
 		}
 
 		dkgRequest := m.GetDKGRequest(ctx, dkgId)
 		if dkgRequest.Status != types.DKGStatus_DKG_STATUS_COMPLETED {
 			return nil, errorsmod.Wrapf(types.ErrInvalidDKGStatus, "dkg %d not completed", dkgId)
 		}
 
+		remainingParticipantNum := len(dkgRequest.Participants) - len(msg.RemovedParticipants)
+		if remainingParticipantNum < types.MinDKGParticipantNum {
+			return nil, errorsmod.Wrapf(types.ErrInvalidParticipants, "remaining participants %d cannot be less than min participants %d", remainingParticipantNum, types.MinDKGParticipantNum)
+		}
+
 		for _, p := range msg.RemovedParticipants {
 			if !slices.Contains(dkgRequest.Participants, p) {
 				return nil, errorsmod.Wrapf(types.ErrInvalidParticipants, "participant %s does not exist for dkg %d", p, dkgId)
 			}
 		}
 
-		m.InitiateRefreshingRequest(ctx, dkgId, msg.RemovedParticipants, msg.NewParticipants, msg.TimeoutDuration)
+		if msg.Thresholds[i] > uint32(remainingParticipantNum) {
+			return nil, errorsmod.Wrapf(types.ErrInvalidThresholds, "threshold %d cannot be greater than participants %d for dkg %d", msg.Thresholds[i], remainingParticipantNum, dkgId)
+		}
+
+		m.InitiateRefreshingRequest(ctx, dkgId, msg.RemovedParticipants, msg.Thresholds[i], msg.TimeoutDuration)
 	}
 
 	return &types.MsgRefreshResponse{}, nil

proto/side/tss/tss.proto

@@ -70,7 +70,7 @@ func (k Keeper) GetRefreshingParticipants(ctx sdk.Context, refreshingRequest *ty
 		}
 	}
 
-	return append(participants, refreshingRequest.NewParticipants...)
+	return participants
 }
 
 // GetRefreshingRequests gets the refreshing requests by the given status
@@ -165,12 +165,12 @@ func (k Keeper) IterateRefreshingCompletions(ctx sdk.Context, id uint64, cb func
 }
 
 // InitiateRefreshingRequest initiates the refreshing request with the specified params
-func (k Keeper) InitiateRefreshingRequest(ctx sdk.Context, dkgId uint64, removedParticipants []string, newParticipants []string, timeoutDuration time.Duration) *types.RefreshingRequest {
+func (k Keeper) InitiateRefreshingRequest(ctx sdk.Context, dkgId uint64, removedParticipants []string, threshold uint32, timeoutDuration time.Duration) *types.RefreshingRequest {
 	req := &types.RefreshingRequest{
 		Id:                  k.IncrementRefreshingRequestId(ctx),
 		DkgId:               dkgId,
 		RemovedParticipants: removedParticipants,
-		NewParticipants:     newParticipants,
+		Threshold:           threshold,
 		ExpirationTime:      types.GetExpirationTime(ctx.BlockTime(), timeoutDuration),
 		Status:              types.RefreshingStatus_REFRESHING_STATUS_PENDING,
 	}
@@ -183,7 +183,7 @@ func (k Keeper) InitiateRefreshingRequest(ctx sdk.Context, dkgId uint64, removed
 			sdk.NewAttribute(types.AttributeKeyId, fmt.Sprintf("%d", req.Id)),
 			sdk.NewAttribute(types.AttributeKeyDKGId, fmt.Sprintf("%d", dkgId)),
 			sdk.NewAttribute(types.AttributeKeyRemovedParticipants, strings.Join(removedParticipants, types.AttributeValueSeparator)),
-			sdk.NewAttribute(types.AttributeKeyNewParticipants, strings.Join(newParticipants, types.AttributeValueSeparator)),
+			sdk.NewAttribute(types.AttributeKeyThreshold, fmt.Sprintf("%d", threshold)),
 			sdk.NewAttribute(types.AttributeKeyExpirationTime, req.ExpirationTime.String()),
 		),
 	)

proto/side/tss/tx.proto

@@ -81,6 +81,12 @@ func handleRefreshingRequests(ctx sdk.Context, k keeper.Keeper) {
 		req.Status = types.RefreshingStatus_REFRESHING_STATUS_COMPLETED
 		k.SetRefreshingRequest(ctx, req)
 
+		// update DKG participants and threshold
+		dkgRequest := k.GetDKGRequest(ctx, req.DkgId)
+		dkgRequest.Participants = k.GetRefreshingParticipants(ctx, req)
+		dkgRequest.Threshold = req.Threshold
+		k.SetDKGRequest(ctx, dkgRequest)
+
 		// Emit events
 		ctx.EventManager().EmitEvent(
 			sdk.NewEvent(

x/tss/keeper/msg_server.go

@@ -25,11 +25,12 @@ var (
 
 	ErrInvalidDKGs                       = errorsmod.Register(ModuleName, 4000, "invalid dkgs")
 	ErrInvalidParticipants               = errorsmod.Register(ModuleName, 4001, "invalid participants")
-	ErrInvalidTimeoutDuration            = errorsmod.Register(ModuleName, 4002, "invalid timeout duration")
-	ErrRefreshingRequestDoesNotExist     = errorsmod.Register(ModuleName, 4003, "refreshing request does not exist")
-	ErrInvalidRefreshingStatus           = errorsmod.Register(ModuleName, 4004, "invalid refreshing status")
-	ErrRefreshingRequestExpired          = errorsmod.Register(ModuleName, 4005, "refreshing request expired")
-	ErrRefreshingCompletionAlreadyExists = errorsmod.Register(ModuleName, 4006, "refreshing completion already exists")
+	ErrInvalidThresholds                 = errorsmod.Register(ModuleName, 4002, "invalid thresholds")
+	ErrInvalidTimeoutDuration            = errorsmod.Register(ModuleName, 4003, "invalid timeout duration")
+	ErrRefreshingRequestDoesNotExist     = errorsmod.Register(ModuleName, 4004, "refreshing request does not exist")
+	ErrInvalidRefreshingStatus           = errorsmod.Register(ModuleName, 4005, "invalid refreshing status")
+	ErrRefreshingRequestExpired          = errorsmod.Register(ModuleName, 4006, "refreshing request expired")
+	ErrRefreshingCompletionAlreadyExists = errorsmod.Register(ModuleName, 4007, "refreshing completion already exists")
 
 	ErrInvalidParams = errorsmod.Register(ModuleName, 5000, "invalid params")
 )

x/tss/keeper/refreshing.go

@@ -31,7 +31,6 @@ const (
 
 	AttributeKeyDKGId               = "dkg_id"
 	AttributeKeyRemovedParticipants = "removed_participants"
-	AttributeKeyNewParticipants     = "new_participants"
 )
 
 const (