downlewd

[backslashxx]

No description provided.

[sidex15]

Might have a problem here... Is 1.5.2 have different userspace offset calls than 1.5.3+ right? That's why i use the local 1.5.4 susfs binaries if download fail or reinstall on no internet connection on 1.5.3+

[backslashxx]

Might have a problem here... Is 1.5.2 have different userspace offset calls than 1.5.3+ right? That's why i use the local 1.5.4 susfs binaries if download fail or reinstall on no internet connection on 1.5.3+

didnt really know which binary you shipped.
I just assumed 152 since thats the folder name

you can rename the function ofc.

--

basically this PR just adresses potential failures

#1. lack of curl on $PATH, so theres a wget fallback
#2. handle failed downloads (un-executable files)

[sidex15]

Well everything is fine except the else statement on 1.5.3+, it should put back the cp ${TMPDIR}/susfs/tools/latest/${KERNEL_VERSION}/ksu_susfs_arm64 ${DEST_BIN_DIR}/ksu_susfs
But anyways should I merge this now and I'll fix it later? Or you have any fixes? I don't have internet for now

[backslashxx]

it should put back the cp ${TMPDIR}/susfs/tools/latest/${KERNEL_VERSION}/ksu_susfs_arm64 ${DEST_BIN_DIR}/ksu_susfs

oh, theres no need for this as I am saving the file on ${MODPATH}/ksu_susfs_remote

susfs4ksu-module/customize.sh

Line 56 in 97511ee

if download "https://raw.githubusercontent.com/sidex15/susfs4ksu-binaries/main/$SUSFS_DECIMAL/$KERNEL_VERSION/ksu_susfs_arm64" > ${MODPATH}/ksu_susfs_remote ; then

and then it does a check, and will use that

susfs4ksu-module/customize.sh

Line 61 in 97511ee

cp -f ${MODPATH}/ksu_susfs_remote ${DEST_BIN_DIR}/ksu_susfs

though yeah I might be missing something, go check

[sidex15]

oh, theres no need for this as I am saving the file on ${MODPATH}/ksu_susfs_remote

susfs4ksu-module/customize.sh

Line 56 in 97511ee

if download "https://raw.githubusercontent.com/sidex15/susfs4ksu-binaries/main/$SUSFS_DECIMAL/$KERNEL_VERSION/ksu_susfs_arm64" > ${MODPATH}/ksu_susfs_remote ; then

and then it does a check, and will use that

susfs4ksu-module/customize.sh

Line 61 in 97511ee

cp -f ${MODPATH}/ksu_susfs_remote ${DEST_BIN_DIR}/ksu_susfs

though yeah I might be missing something, go check

Well that code snippet requires an internet right?
What i meant is in line 64 and 70 mainly the call of use_susfs_152_binary function needs to be replaced back to the code i mentioned previously since it's under 1.5.3+. That ensures a fall back when the internet is down or reinstall without an internet connection on users that use 1.5.3+ kernel. AFAIK 1.5.2 and 1.5.3+ have different calls from the userspace binaries to the kernel.

[backslashxx]

ah yeah, got it, I only noticed it now that theres a "latest" folder

[sidex15]

Nice
I think this LGTM!
Thanks!
Will merge...