Skip to content

Commit 718ce0f

Browse files
committed
Fix remaining mock paths and dynamic aggregation test in util-genai-evals
- Fix 4 instances of handler._load_completion_callbacks -> utils.load_completion_callbacks in test_evaluators.py - Fix test_evaluation_dynamic_aggregation.py to set _aggregate_results to None instead of False to enable dynamic environment variable reading as per actual implementation (cherry picked from commit a20742f)
1 parent 0087986 commit 718ce0f

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

util/opentelemetry-util-genai-evals/tests/test_evaluation_dynamic_aggregation.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ def test_dynamic_aggregation_env_toggle(monkeypatch): # type: ignore[no-untyped
3232
[EvaluationResult(metric_name="bias", score=0.1)],
3333
[EvaluationResult(metric_name="toxicity", score=0.3)],
3434
]
35-
# Disable internal aggregate flag
36-
manager._aggregate_results = False
35+
# Set internal aggregate flag to None to enable dynamic env var reading
36+
manager._aggregate_results = None
3737
manager._publish_results(invocation, buckets)
38-
assert len(handler.calls) == 2 # two separate batches
38+
assert len(handler.calls) == 2 # two separate batches (env var not set)
3939

4040
# Now enable aggregation via env and emit again -> should aggregate
4141
monkeypatch.setenv( # type: ignore[attr-defined]

util/opentelemetry-util-genai-evals/tests/test_evaluators.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ def _build_invocation(self) -> LLMInvocation:
237237
)
238238
def test_handler_registers_manager(self) -> None:
239239
with patch(
240-
"opentelemetry.util.genai.handler._load_completion_callbacks",
240+
"opentelemetry.util.genai.utils.load_completion_callbacks",
241241
side_effect=_mock_load_callbacks,
242242
):
243243
handler = get_telemetry_handler()
@@ -263,7 +263,7 @@ def test_handler_registers_manager(self) -> None:
263263
)
264264
def test_handler_evaluate_llm_returns_results(self) -> None:
265265
with patch(
266-
"opentelemetry.util.genai.handler._load_completion_callbacks",
266+
"opentelemetry.util.genai.utils.load_completion_callbacks",
267267
side_effect=_mock_load_callbacks,
268268
):
269269
handler = get_telemetry_handler()
@@ -287,7 +287,7 @@ def test_handler_auto_enables_when_env_missing(self) -> None:
287287
return_value={"LLMInvocation": ("static_metric",)},
288288
),
289289
patch(
290-
"opentelemetry.util.genai.handler._load_completion_callbacks",
290+
"opentelemetry.util.genai.utils.load_completion_callbacks",
291291
side_effect=_mock_load_callbacks,
292292
),
293293
):
@@ -305,7 +305,7 @@ def test_handler_auto_enables_when_env_missing(self) -> None:
305305
)
306306
def test_handler_disables_when_none(self) -> None:
307307
with patch(
308-
"opentelemetry.util.genai.handler._load_completion_callbacks",
308+
"opentelemetry.util.genai.utils.load_completion_callbacks",
309309
side_effect=_mock_load_callbacks,
310310
):
311311
handler = get_telemetry_handler()

0 commit comments

Comments
 (0)