Skip to content

utils.get_command_from_result assumes that waf is always the building system #78

@Thecave3

Description

@Thecave3

For sure a minor issue, but worth reporting: utils.get_command_from_result assumes that waf is always the building system

sem/sem/utils.py

Lines 104 to 122 in 6a39f0a

def get_command_from_result(script, result, debug=False):
"""
Return the command that is needed to obtain a certain result.
Args:
params (dict): Dictionary containing parameter: value pairs.
debug (bool): Whether the command should include the debugging
template.
"""
if not debug:
command = "python3 waf --run \"" + script + " " + " ".join(
['--%s=%s' % (param, value) for param, value in
result['params'].items()]) + "\""
else:
command = "python3 waf --run " + script + " --command-template=\"" +\
"gdb --args %s " + " ".join(['--%s=%s' % (param, value) for
param, value in
result['params'].items()]) + "\""
return command

Implementing something like this may help

if os.path.exists(os.path.join(self.path, "ns3")):

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinginvalidThis doesn't seem right

    Type

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions