Adopt SSP coding-style

Author: tvdijen

src/Auth/InvalidCredentialResult.php

@@ -26,15 +26,25 @@ class InvalidCredentialResult
      * @see https://ldapwiki.com/wiki/Common%20Active%20Directory%20Bind%20Errors
      */
     public const LDAP_NO_SUCH_OBJECT = '525';
+
     public const ERROR_LOGON_FAILURE = '52e';
+
     public const ERROR_ACCOUNT_RESTRICTION = '52f';
+
     public const ERROR_INVALID_LOGON_HOURS = '530';
+
     public const ERROR_INVALID_WORKSTATION = '531';
+
     public const ERROR_PASSWORD_EXPIRED = '532';
+
     public const ERROR_ACCOUNT_DISABLED = '533';
+
     public const ERROR_TOO_MANY_CONTEXT_IDS = '568';
+
     public const ERROR_ACCOUNT_EXPIRED = '701';
+
     public const ERROR_PASSWORD_MUST_CHANGE = '773';
+
     public const ERROR_ACCOUNT_LOCKED_OUT = '775';
 
     /**
@@ -43,17 +53,23 @@ class InvalidCredentialResult
      * N.B. - This is an incomplete list
      */
     public const NT_STATUS_PASSWORD_EXPIRED = 'PASSWORD_EXPIRED';
+
     public const NT_STATUS_PASSWORD_MUST_CHANGE = 'PASSWORD_MUST_CHANGE';
+
     public const NT_STATUS_LOGON_FAILURE = 'LOGON_FAILURE';
 
     /**
      * List of keys for the code mapping
      */
     public const KEY_INVALID_CREDENTIAL = 'invalid_credential';
+
     public const KEY_PASSWORD_ERROR = 'password_error';
+
     public const KEY_ACCOUNT_ERROR = 'account_error';
+
     public const KEY_RESTRICTION = 'restriction';
 
+
     /**
      * Map of keys to check the code against when using is* methods
      *

src/Auth/Process/AttributeAddFromLDAP.php

@@ -52,6 +52,7 @@ class AttributeAddFromLDAP extends BaseFilter
     /** @var string|null */
     protected ?string $searchPassword;
 
+
     /**
      * Initialize this filter.
      *

src/Auth/Process/BaseFilter.php

@@ -11,7 +11,10 @@
 
 namespace SimpleSAML\Module\ldap\Auth\Process;
 
-use SimpleSAML\{Auth, Configuration, Error, Logger};
+use SimpleSAML\Auth;
+use SimpleSAML\Configuration;
+use SimpleSAML\Error;
+use SimpleSAML\Logger;
 use SimpleSAML\Module\ldap\ConnectorFactory;
 use SimpleSAML\Module\ldap\ConnectorInterface;
 

src/Auth/Source/Ldap.php

@@ -163,6 +163,7 @@ protected function loginSasl(
         return $this->processAttributes(/** @scrutinizer-ignore-type */$entry);
     }
 
+
     /**
      * Attempt to log in using the given username and password.
      *

src/Connector/ActiveDirectory.php

@@ -14,7 +14,9 @@
 class ActiveDirectory extends Ldap
 {
     public const ERR_PASSWORD_RESET = 'RESETPASSWORD';
+
     public const ERR_ACCOUNT_RESET = 'RESETACCOUNT';
+
     public const ERR_LOGON_RESTRICTION = 'LOGONRESTRICTION';
 
 

src/Connector/Ldap.php

@@ -27,6 +27,7 @@ class Ldap implements ConnectorInterface
 {
     use LdapHelpers;
 
+
     /**
      * @var \Symfony\Component\Ldap\Adapter\AdapterInterface
      */
@@ -109,6 +110,7 @@ public function bind(?string $username, #[\SensitiveParameter]?string $password)
         }
     }
 
+
     /**
      * @inheritDoc
      */
@@ -138,6 +140,7 @@ public function saslBind(
         }
     }
 
+
     /**
      * @inheritDoc
      */
@@ -150,6 +153,7 @@ public function whoami(): string
         return $this->connection->whoami();
     }
 
+
     /**
      * @inheritDoc
      */

tests/src/Auth/Source/LdapTest.php

@@ -29,6 +29,7 @@ public static function setUpBeforeClass(): void
         Configuration::setPreLoadedConfig($sourceConfig, 'authsources.php');
     }
 
+
     public function buildSourceMock(): Ldap
     {
         $mb = $this->getMockBuilder(ConnectorInterface::class);
@@ -51,11 +52,12 @@ public function __construct(ConnectorInterface $connector)
         };
     }
 
+
     public function testLogin(): void
     {
         $source = $this->buildSourceMock();
-        /** @psalm-var \PHPUnit\Framework\MockObject\MockObject $connector */
         $connector = $source->getConnector();
+        /** @phpstan-ignore method.notFound */
         $connector->method('search')->willReturn(
             new Entry('test', ['test1' => ['testval1']]),
         );
@@ -76,8 +78,8 @@ public function testLogin(): void
     public function testGetAttributes(): void
     {
         $source = $this->buildSourceMock();
-        /** @psalm-var \PHPUnit\Framework\MockObject\MockObject $connector */
         $connector = $source->getConnector();
+        /** @phpstan-ignore method.notFound */
         $connector->method('search')->willReturn(
             new Entry('test', ['test2' => ['testval2']]),
         );
@@ -90,7 +92,7 @@ public function testGetAttributes(): void
     public function testGetAttributesWithAttributesSetToNull(): void
     {
         $source = $this->buildSourceMock();
-        /** @psalm-var \PHPUnit\Framework\MockObject\MockObject $connector */
+        /** @phpstan-ignore method.notFound */
         $connector = $source->getConnector();
         $connector->method('search')->willReturn(
             new Entry('test', ['test1' => ['testval1'], 'test2' => ['testval2'], 'test3' => ['testval3']]),