⚡️ Add check that deleted folder is returned, also add some performance improvements

Author: kzscisoft

simvue/api/objects/base.py

@@ -412,6 +412,10 @@ def get(
                     f"Expected key 'data' for retrieval of {_class_instance.__class__.__name__.lower()}s"
                 )
 
+            # If data is an empty list
+            if not _data:
+                return
+
             for entry in _data:
                 _id = entry["id"]
                 yield _id, cls(_read_only=True, identifier=_id, _local=True, **entry)

simvue/client.py

@@ -32,7 +32,16 @@
 from .models import FOLDER_REGEX, NAME_REGEX
 from .config.user import SimvueConfiguration
 from .api.request import get_json_from_response
-from .api.objects import Run, Folder, Tag, Artifact, Alert, FileArtifact, ObjectArtifact
+from .api.objects import (
+    Run,
+    Folder,
+    Tag,
+    Artifact,
+    Alert,
+    FileArtifact,
+    ObjectArtifact,
+    get_folder_from_path,
+)
 
 
 CONCURRENT_DOWNLOADS = 10
@@ -429,6 +438,9 @@ def delete_folder(
             delete_runs=remove_runs, recursive=recursive, runs_only=False
         )
 
+        if folder_path not in _response.get("folders", []):
+            raise RuntimeError("Deletion of folder failed, server returned mismatch.")
+
         return _response.get("runs", [])
 
     @prettify_pydantic
@@ -665,17 +677,12 @@ def get_folder(
         RuntimeError
             if there was a failure when retrieving information from the server
         """
-        _folders: typing.Generator[tuple[str, Folder], None, None] = Folder.get(
-            filters=json.dumps([f"path == {folder_path}"])
-        )  # type: ignore
-
         try:
-            _, _folder = next(_folders)
-            if not read_only:
-                _folder.read_only(read_only)
-            return _folder
-        except StopIteration:
+            _folder = get_folder_from_path(path=folder_path)
+        except ObjectNotFoundError:
             return None
+        _folder.read_only(is_read_only=read_only)
+        return _folder
 
     @pydantic.validate_call
     def get_folders(