Merge pull request #427 from simvue-io/hotfix/no-hang-on-api-call

kzscisoft · web-flow · commit 19cec9fe360b · 2024-06-14T13:17:34.000+01:00
Do not join threads in online dispatch callback
diff --git a/simvue/run.py b/simvue/run.py
@@ -382,7 +382,7 @@ def _online_dispatch_callback(
                     url=_url, headers=_msgpack_header, data=_data_bin, is_json=False
                 )
             except (ValueError, RuntimeError) as e:
-                self._error(f"{e}")
+                self._error(f"{e}", join_threads=False)
                 return
 
         return (

Original file line number	Diff line number	Diff line change
`@@ -382,7 +382,7 @@ def _online_dispatch_callback(`
`382`	`382`	`url=_url, headers=_msgpack_header, data=_data_bin, is_json=False`
`383`	`383`	`)`
`384`	`384`	`except (ValueError, RuntimeError) as e:`
`385`		`- self._error(f"{e}")`
	`385`	`+ self._error(f"{e}", join_threads=False)`
`386`	`386`	`return`
`387`	`387`
`388`	`388`	`return (`