Merge pull request #544 from simvue-io/hotfix/keyboard-interrupt-feedback

Handle KeyboardInterrupt and Exceptions

Author: kzscisoft

CHANGELOG.md

@@ -3,6 +3,8 @@
 ## Unreleased
 
 * Ensure all functionality is deactivated when mode is set to `disabled`.
+* When an exception is thrown an event is sent to Simvue displaying the traceback.
+* If `add_process` is used and an exception is thrown, `.err` and `.out` files are still uploaded.
 
 ## [v1.0.4](https://github.com/simvue-io/client/releases/tag/v1.0.4) - 2024-09-24
 

simvue/executor.py

@@ -414,6 +414,8 @@ def kill_process(
             process.kill()
             process.wait()
 
+        self._save_output()
+
     def kill_all(self) -> None:
         """Kill all running processes"""
         for process in self._processes.keys():

simvue/run.py

@@ -20,6 +20,7 @@
 import pydantic
 import re
 import sys
+import traceback as tb
 import time
 import functools
 import platform
@@ -166,11 +167,19 @@ def _handle_exception_throw(
         if not _is_running:
             return
 
-        self.set_status("terminated" if _is_terminated else "failed")
-
         if not self._active:
             return
 
+        _traceback_out: list[str] = tb.format_exception(exc_type, value, traceback)
+        _event_msg: str = (
+            "\n".join(_traceback_out)
+            if _traceback_out
+            else f"An exception was thrown: {_exception_thrown}"
+        )
+
+        self.log_event(_event_msg)
+        self.set_status("terminated" if _is_terminated else "failed")
+
         # If the dispatcher has already been aborted then this will
         # fail so just continue without the event
         with contextlib.suppress(RuntimeError):
@@ -1415,7 +1424,8 @@ def _tidy_run(self) -> None:
         if self._status == "running":
             if self._dispatcher:
                 self._dispatcher.join()
-            self.set_status("completed")
+            if self._active:
+                self.set_status("completed")
         elif self._dispatcher:
             self._dispatcher.purge()
             self._dispatcher.join()