Fix checking for empty as opposed to None in object retrieval

kzscisoft · kzscisoft · commit 26986be8ad2a · 2024-06-07T08:47:50.000+01:00
diff --git a/simvue/client.py b/simvue/client.py
@@ -342,7 +342,7 @@ def get_runs(
                 f"but got '{type(json_response)}'"
             )
 
-        if response_data := json_response.get("data"):
+        if (response_data := json_response.get("data")) is not None:
             return response_data
         elif output_format == "dataframe":
             return to_dataframe(response.json())
@@ -877,7 +877,7 @@ def get_folders(
                 f"but got '{type(json_response)}'"
             )
 
-        if not (data := json_response.get("data")):
+        if (data := json_response.get("data")) is None:
             raise RuntimeError(
                 "Expected key 'data' in response during folder retrieval"
             )

Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,7 @@ def get_runs(`
`342`	`342`	`f"but got '{type(json_response)}'"`
`343`	`343`	`)`
`344`	`344`
`345`		`- if response_data := json_response.get("data"):`
	`345`	`+ if (response_data := json_response.get("data")) is not None:`
`346`	`346`	`return response_data`
`347`	`347`	`elif output_format == "dataframe":`
`348`	`348`	`return to_dataframe(response.json())`
`@@ -877,7 +877,7 @@ def get_folders(`
`877`	`877`	`f"but got '{type(json_response)}'"`
`878`	`878`	`)`
`879`	`879`
`880`		`- if not (data := json_response.get("data")):`
	`880`	`+ if (data := json_response.get("data")) is None:`
`881`	`881`	`raise RuntimeError(`
`882`	`882`	`"Expected key 'data' in response during folder retrieval"`
`883`	`883`	`)`