Skip to content

Commit 4956768

Browse files
committed
Merge branch 'dev' into feature/toml-config
2 parents f3e368f + 8e15a5c commit 4956768

File tree

7 files changed

+43
-23
lines changed

7 files changed

+43
-23
lines changed

.github/workflows/deploy.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ jobs:
7979
name: python-package-distributions
8080
path: dist/
8181
- name: Sign the dists with Sigstore
82-
uses: sigstore/gh-action-sigstore-python@v3
82+
uses: sigstore/gh-action-sigstore-python@v3.0.0
8383
with:
8484
inputs: >-
8585
./dist/*.tar.gz

.github/workflows/test_client_ubuntu.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
export SIMVUE_TOKEN=${{ secrets.SIMVUE_TOKEN }}
3737
poetry install --all-extras
3838
poetry run python -m pip install torch --index-url https://download.pytorch.org/whl/cpu
39-
poetry run pytest -x --cov --cov-report=xml tests/unit/ tests/refactor/ -m 'not scenario'
39+
poetry run pytest -x --cov --cov-report=xml tests/unit/ tests/refactor/ -m 'not scenario' --no-config -p no:warnings -n 0
4040
- name: Upload coverage reports to Codecov
4141
run: |
4242
curl -Os https://uploader.codecov.io/latest/linux/codecov

.pre-commit-config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ ci:
88
submodules: false
99
repos:
1010
- repo: https://github.com/pre-commit/pre-commit-hooks
11-
rev: v4.6.0
11+
rev: v5.0.0
1212
hooks:
1313
- id: check-toml
1414
- id: check-yaml
@@ -23,7 +23,7 @@ repos:
2323
args: [--branch, main, --branch, dev]
2424
- id: check-added-large-files
2525
- repo: https://github.com/astral-sh/ruff-pre-commit
26-
rev: v0.6.8
26+
rev: v0.6.9
2727
hooks:
2828
- id: ruff
2929
args: [ --fix, --exit-non-zero-on-fix, "--ignore=C901" ]

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,16 @@
22

33
## Unreleased
44

5+
* Add option to specify a callback executed when an alert is triggered for a run.
6+
* Allow retrieval of all alerts when no constraints are specified.
7+
* Add carbon emissions statistics as optional metrics.
8+
* Include Python and Rust environment metadata.
9+
* Allow the disabling of heartbeat to allow runs to continue indefinitely.
10+
* Verify Simvue server URL as early as possible.
11+
* Indicate the source used for token and URL.
512
* Ensure all functionality is deactivated when mode is set to `disabled`.
13+
* When an exception is thrown an event is sent to Simvue displaying the traceback.
14+
* If `add_process` is used and an exception is thrown, `.err` and `.out` files are still uploaded.
615

716
## [v1.0.4](https://github.com/simvue-io/client/releases/tag/v1.0.4) - 2024-09-24
817

poetry.lock

Lines changed: 19 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

simvue/executor.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,8 @@ def kill_process(
420420
process.kill()
421421
process.wait()
422422

423+
self._save_output()
424+
423425
def kill_all(self) -> None:
424426
"""Kill all running processes"""
425427
for process in self._processes.keys():

simvue/run.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import pydantic
2020
import re
2121
import sys
22+
import traceback as tb
2223
import time
2324
import functools
2425
import platform
@@ -210,6 +211,14 @@ def _handle_exception_throw(
210211
if not self._active:
211212
return
212213

214+
_traceback_out: list[str] = tb.format_exception(exc_type, value, traceback)
215+
_event_msg: str = (
216+
"\n".join(_traceback_out)
217+
if _traceback_out
218+
else f"An exception was thrown: {_exception_thrown}"
219+
)
220+
221+
self.log_event(_event_msg)
213222
self.set_status("terminated" if _is_terminated else "failed")
214223

215224
# If the dispatcher has already been aborted then this will

0 commit comments

Comments
 (0)