Merge pull request #387 from simvue-io/hotfix/handle-numpy-object-response

wk9874 · web-flow · commit 7f45da32f7d9 · 2024-06-05T10:31:37.000+01:00
Fix ambiguity issue with numpy artifact retrieval
diff --git a/simvue/client.py b/simvue/client.py
@@ -641,7 +641,9 @@ def get_artifact(
             response.content, mimetype, allow_pickle
         )
 
-        return content or response.content
+        # Numpy array return means just 'if content' will be ambiguous
+        # so must explicitly check if None
+        return response.content if content is None else content
 
     @prettify_pydantic
     @pydantic.validate_call

Original file line number	Diff line number	Diff line change
`@@ -641,7 +641,9 @@ def get_artifact(`
`641`	`641`	`response.content, mimetype, allow_pickle`
`642`	`642`	`)`
`643`	`643`
`644`		`- return content or response.content`
	`644`	`+ # Numpy array return means just 'if content' will be ambiguous`
	`645`	`+ # so must explicitly check if None`
	`646`	`+ return response.content if content is None else content`
`645`	`647`
`646`	`648`	`@prettify_pydantic`
`647`	`649`	`@pydantic.validate_call`