Skip to content

Commit 9c0c71f

Browse files
committed
🐛 Use daemon=True in Thread creation
1 parent 2f44e61 commit 9c0c71f

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

simvue/executor.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ def trigger_check(
8080
thread_out = threading.Thread(
8181
target=trigger_check,
8282
args=(completion_callback, completion_trigger, _result),
83+
daemon=True,
8384
)
8485
thread_out.start()
8586

simvue/run.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,7 @@ def _start(self) -> bool:
539539
)
540540

541541
self._heartbeat_thread = threading.Thread(
542-
target=self._create_heartbeat_callback()
542+
target=self._create_heartbeat_callback(), daemon=True
543543
)
544544

545545
except RuntimeError as e:

tests/functional/test_dispatch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ def _main(res_queue, index, dispatch_callback=create_callback, term_event=event,
127127
threads = []
128128

129129
for i in range(3):
130-
_thread = Thread(target=_main, args=(result_queue, i,))
130+
_thread = Thread(target=_main, args=(result_queue, i,), daemon=True)
131131
_thread.start()
132132
threads.append(_thread)
133133

tests/functional/test_scenarios.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def test_uploaded_data_immediately_accessible(
123123
else:
124124
if processing == "on_thread":
125125
thread = threading.Thread(
126-
target=upload, args=(name, values_per_run, shared_dict)
126+
target=upload, args=(name, values_per_run, shared_dict), daemon=True
127127
)
128128
else:
129129
thread = Process(target=upload, args=(name, values_per_run, shared_dict))

0 commit comments

Comments
 (0)