Use sigkill to prevent zombies

Author: kzscisoft

simvue/executor.py

@@ -308,8 +308,12 @@ def kill_process(self, process_id: str) -> None:
             logger.debug(f"Terminating child process {child.pid}: {child.name()}")
             child.kill()
 
+        for child in parent.children(recursive=True):
+            child.wait()
+
         logger.debug(f"Terminating child process {process.pid}: {process.args}")
-        process.terminate()
+        process.kill()
+        process.wait()
 
         self._execute_callback(process_id)
 

tests/refactor/test_run_class.py

@@ -517,6 +517,15 @@ def testing_exit(status: int) -> None:
 def test_kill_all_processes(create_plain_run: typing.Tuple[sv_run.Run, dict]) -> None:
     run, _ = create_plain_run
     run.config(resources_metrics_interval=1)
-    run.add_process(identifier="forever_long", executable="bash", c="sleep 10000")
+    run.add_process(identifier="forever_long_1", executable="bash", c="sleep 10000")
+    run.add_process(identifier="forever_long_2", executable="bash", c="sleep 10000")
+    processes = [
+        psutil.Process(process.pid)
+        for process in run._executor._processes.values()
+    ]
     time.sleep(2)
     run.kill_all_processes()
+    time.sleep(4)
+    for process in processes:
+        assert not process.is_running()
+        assert all(not child.is_running() for child in process.children(recursive=True))