Merge pull request #476 from simvue-io/hotfix/correct-wrong-http-code

kzscisoft · web-flow · commit f46e71704ae0 · 2024-08-06T08:10:54.000Z
Correct wrong HTTP status code check 400 -&gt; 404
diff --git a/simvue/client.py b/simvue/client.py
@@ -613,7 +613,7 @@ def _retrieve_artifact_from_server(
         )
 
         json_response = self._get_json_from_response(
-            expected_status=[200, 400],
+            expected_status=[200, 404],
             scenario=f"Retrieval of artifact '{name}' for run '{run_id}'",
             response=response,
         )
@@ -652,7 +652,7 @@ def abort_run(self, run_id: str, reason: str) -> typing.Union[dict, list]:
         )
 
         json_response = self._get_json_from_response(
-            expected_status=[200, 400],
+            expected_status=[200, 404],
             scenario=f"Abort of run '{run_id}'",
             response=response,
         )

Original file line number	Diff line number	Diff line change
`@@ -613,7 +613,7 @@ def _retrieve_artifact_from_server(`
`613`	`613`	`)`
`614`	`614`
`615`	`615`	`json_response = self._get_json_from_response(`
`616`		`- expected_status=[200, 400],`
	`616`	`+ expected_status=[200, 404],`
`617`	`617`	`scenario=f"Retrieval of artifact '{name}' for run '{run_id}'",`
`618`	`618`	`response=response,`
`619`	`619`	`)`
`@@ -652,7 +652,7 @@ def abort_run(self, run_id: str, reason: str) -> typing.Union[dict, list]:`
`652`	`652`	`)`
`653`	`653`
`654`	`654`	`json_response = self._get_json_from_response(`
`655`		`- expected_status=[200, 400],`
	`655`	`+ expected_status=[200, 404],`
`656`	`656`	`scenario=f"Abort of run '{run_id}'",`
`657`	`657`	`response=response,`
`658`	`658`	`)`