Allow files to be saved for runs in the created state

Author: alahiff

simvue/run.py

@@ -525,10 +525,6 @@ def save(self, filename, category, filetype=None, preserve_path=False, name=None
             self._error(INIT_MISSING)
             return False
 
-        if not self._active:
-            self._error('Run is not active')
-            return False
-
         is_file = False
         if isinstance(filename, str):
             if not os.path.isfile(filename):

tests/functional/test_artifacts_code_created.py

@@ -0,0 +1,42 @@
+import configparser
+import filecmp
+import os
+import shutil
+import time
+import unittest
+import uuid
+from simvue import Run, Client
+from simvue.sender import sender
+
+import common
+
+class TestArtifactsCreatedState(unittest.TestCase):
+    def test_artifact_code_created(self):
+        """
+        Create a run & an artifact of type 'code' & check it can be downloaded for
+        a run left in the created state
+        """
+        run = Run()
+        run.init(common.RUNNAME1, folder=common.FOLDER, running=False)
+
+        content = str(uuid.uuid4())
+        with open(common.FILENAME1, 'w') as fh:
+            fh.write(content)
+        run.save(common.FILENAME1, 'code')
+
+        shutil.rmtree('./test', ignore_errors=True)
+        os.mkdir('./test')
+
+        client = Client()
+        client.get_artifact_as_file(common.RUNNAME1, common.FILENAME1, './test')
+
+        self.assertTrue(filecmp.cmp(common.FILENAME1, './test/%s' % common.FILENAME1))
+
+        runs = client.delete_runs(common.FOLDER)
+        self.assertEqual(len(runs), 1)
+
+        shutil.rmtree('./test', ignore_errors=True)
+        os.remove(common.FILENAME1)
+
+if __name__ == '__main__':
+    unittest.main()