Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU & memory resource usage not measured when set_pid is used #718

Open
alahiff opened this issue Feb 21, 2025 · 1 comment
Open

CPU & memory resource usage not measured when set_pid is used #718

alahiff opened this issue Feb 21, 2025 · 1 comment
Assignees
Labels
ready for testing This issue has been fixed and is ready for testing
Milestone

Comments

@alahiff
Copy link
Collaborator

alahiff commented Feb 21, 2025

Version tested: 2.0.0a1

@wk9874 wk9874 added the backlog Waiting to be resolved label Feb 21, 2025
@wk9874 wk9874 added this to the v2.0.0-rc1 milestone Feb 21, 2025
@wk9874 wk9874 self-assigned this Feb 24, 2025
@wk9874 wk9874 added in progress Work is being done to resolve this issue and removed backlog Waiting to be resolved labels Feb 24, 2025
@wk9874
Copy link
Collaborator

wk9874 commented Feb 24, 2025

This will probably be because set_pid updates self._pid, but self._parent_process, which is used in the generation of the lists of processes to collect stats from, is only set equal to self._pid inside run.init(). To fix, just going to add a self._parent_process = psutil.Process(self._pid) into set_pid

@wk9874 wk9874 added in review This issue is resolved in a Pull Request which is being reviewed and removed in progress Work is being done to resolve this issue labels Feb 25, 2025
@wk9874 wk9874 mentioned this issue Feb 27, 2025
@wk9874 wk9874 added ready for testing This issue has been fixed and is ready for testing and removed in review This issue is resolved in a Pull Request which is being reviewed labels Feb 27, 2025
@wk9874 wk9874 assigned alahiff and unassigned wk9874 Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for testing This issue has been fixed and is ready for testing
Projects
None yet
Development

No branches or pull requests

2 participants