Skip to content

Fixed issue with exception throws causing hangs #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

kzscisoft
Copy link
Collaborator

Refactor exit methods to use same sub-methods and ensure exception throws do not lead to hangs due to waiting for process completion.

@kzscisoft kzscisoft added the bug Something isn't working label Sep 11, 2024
@kzscisoft kzscisoft requested a review from alahiff September 11, 2024 16:17
@kzscisoft kzscisoft linked an issue Sep 11, 2024 that may be closed by this pull request
Fixed issue with exception throws causing hangs
@kzscisoft kzscisoft force-pushed the 507-client-gets-stuck-if-gpu-runs-out-of-memory branch from c0705e2 to 9806e02 Compare September 11, 2024 16:20
@kzscisoft kzscisoft changed the base branch from dev to v1.0 September 11, 2024 16:20
Copy link
Collaborator

@alahiff alahiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these changes the client works reliably for me normally, when killed by control-c, and when an exception is raised.

@kzscisoft kzscisoft merged commit cae67ad into v1.0 Sep 12, 2024
1 check passed
@kzscisoft kzscisoft deleted the 507-client-gets-stuck-if-gpu-runs-out-of-memory branch September 12, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client gets stuck if GPU runs out of memory
2 participants