Skip to content

Add Alert Validator #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Add Alert Validator #632

wants to merge 6 commits into from

Conversation

wk9874
Copy link
Collaborator

@wk9874 wk9874 commented Dec 16, 2024

Add Alert Validator

Issue: #630

Python Version(s) Tested: 3.10

Operating System(s): Ubuntu 22.04

📝 Summary

Previously, the Integrations and Optimisation repo have used an alert validator when creating alerts. This means that the code is duplicated across both repos and drifts out of date with the main python API create_alert requirements. Should be added to the python API instead so that the other two repos can use the same version, can be kept up to date if create_alert changes.

🔄 Changes

Added AlertValidator pydantic class
Pass inputs to create_alert through validator to check they are valid
Remove if statements which this client should catch instead
Added tests

(Also I know I shouldn't have added this here, but added pre-commit as a dev requirement :) )

✔️ Checklist

  • Unit and integration tests passing.
  • Pre-commit hooks passing.
  • Quality checks passing.

@wk9874
Copy link
Collaborator Author

wk9874 commented Feb 18, 2025

No longer required - see #630 and #688

@wk9874 wk9874 closed this Feb 18, 2025
@kzscisoft kzscisoft deleted the wk9874/alert_validator branch May 12, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant