Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Alert Validator
Issue: #630
Python Version(s) Tested: 3.10
Operating System(s): Ubuntu 22.04
📝 Summary
Previously, the Integrations and Optimisation repo have used an alert validator when creating alerts. This means that the code is duplicated across both repos and drifts out of date with the main python API create_alert requirements. Should be added to the python API instead so that the other two repos can use the same version, can be kept up to date if
create_alert
changes.🔄 Changes
Added AlertValidator pydantic class
Pass inputs to
create_alert
through validator to check they are validRemove if statements which this client should catch instead
Added tests
(Also I know I shouldn't have added this here, but added pre-commit as a dev requirement :) )
✔️ Checklist