-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule proposal: name-dialect #2520
Comments
I like the idea, but may it can be done by spellcheck? |
I think a spellcheck will be too annoying for variable names. It will have too many false-positives and words it doesn't know. It's easier to manually define a list of common spelling inconsistencies. We could reuse the machinery from |
From a "support" point of view, this should probably be added if there's a short and complete list of such words, otherwise you'll end up having to tweak it regularly via "feature requests" issues. |
Most spellcheckers would probably have both variants pass. Also, many of them are a pain to set up because they tend to have too many false-positives (I use So I do support this proposal, I assume the list will be pretty short. |
Description
Enforce consistent dialect (Commonweath/British or American) for function and variable names
Fail
When
['error', 'american']
:When
['error', 'commonwealth']
:Pass
When
['error', 'american']
:When
['error', 'commonwealth']
:Proposed rule name
name-dialect
Additional Info
No response
The text was updated successfully, but these errors were encountered: