no-unnecessary-polyfills false positive for regexp.escape

[kevinoid]

The unicorn/no-unnecessary-polyfills rule is triggered by importing regexp.escape in a package with engines.node: ">=18". I believe this is a false-positive since RegExp.escape() is not supported by any version of Node.js (also confirmed by the core-js compat table).

Full reproduction:

npm init -y
npm pkg set type=module
npm pkg set engines.node=">=18"
npm install -D eslint eslint-plugin-unicorn
echo "import eslintPluginUnicorn from 'eslint-plugin-unicorn';
export default [eslintPluginUnicorn.configs.recommended];" >eslint.config.js
npm install regexp.escape
echo "import regexpEscape from 'regexp.escape';" >index.js
./node_modules/.bin/eslint .

I've bisected the regression to zloirock/core-js@7321cc1 ([email protected]) which added the feature es.regexp.escape.

The crux of the issue appears to be that coreJsCompat.entries['core-js/full/regexp/escape'] is ['es.regexp.escape', 'esnext.regexp.escape'] while coreJsCompat({ node: '>=18' }).list contains 'es.regexp.escape' but not 'esnext.regexp.escape', causing checkFeatures() to return true at

eslint-plugin-unicorn/rules/no-unnecessary-polyfills.js

Line 133 in e48a620

if (checkFeatures(features)) {

Thanks,
Kevin