Minor refactorings (#612)

* Fix GC issue

* Disable tests and delete everything during setup

* Fix bug regarding concurrent/parallel access.

* Minor refactorings

* Disabled tests

* Update build.gradle

---------

Co-authored-by: Johannes Lichtenberger <[email protected]>

Author: JohannesLichtenberger

bundles/sirix-core/src/main/java/org/sirix/access/ResourceConfiguration.java

@@ -40,7 +40,7 @@
 import org.sirix.io.bytepipe.ByteHandler;
 import org.sirix.io.bytepipe.ByteHandlerKind;
 import org.sirix.io.bytepipe.ByteHandlerPipeline;
-import org.sirix.io.bytepipe.SnappyCompressor;
+import org.sirix.io.bytepipe.LZ4Compressor;
 import org.sirix.node.NodeSerializerImpl;
 import org.sirix.node.interfaces.RecordSerializer;
 import org.sirix.settings.VersioningType;
@@ -723,7 +723,7 @@ public Builder(final String resource) {
       this.resource = requireNonNull(resource);
       pathSummary = true;
       storeChildCount = true;
-      byteHandler = new ByteHandlerPipeline(new SnappyCompressor());//new LZ4Compressor()); // new Encryptor(path));
+      byteHandler = new ByteHandlerPipeline(new LZ4Compressor()); // new Encryptor(path));
     }
 
     /**

bundles/sirix-core/src/main/java/org/sirix/io/AbstractReader.java

@@ -34,12 +34,7 @@ public AbstractReader(ByteHandler byteHandler, PagePersister pagePersister, Seri
   public Page deserialize(PageReadOnlyTrx pageReadTrx, byte[] page) throws IOException {
     // perform byte operations
     final var inputStream = byteHandler.deserialize(new ByteArrayInputStream(page));
-    byte[] bytes = inputStream.readAllBytes();
-    var input = Bytes.elasticByteBuffer(10_000);
-    BytesUtils.doWrite(input, bytes);
-    final var deserializedPage = pagePersister.deserializePage(pageReadTrx, input, type);
-    input.clear();
-    return deserializedPage;
+    return pagePersister.deserializePage(pageReadTrx, Bytes.wrapForRead(inputStream.readAllBytes()), type);
   }
 
   @Override

bundles/sirix-core/src/main/java/org/sirix/io/bytepipe/LZ4Compressor.java

@@ -1,37 +1,26 @@
 package org.sirix.io.bytepipe;
 
-import net.jpountz.lz4.LZ4FrameInputStream;
-import net.jpountz.lz4.LZ4FrameOutputStream;
+import net.jpountz.lz4.LZ4BlockInputStream;
+import net.jpountz.lz4.LZ4BlockOutputStream;
 
-import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
-import java.io.UncheckedIOException;
 
 /**
  * LZ4 compression/decompression.
  *
  * @author Johannes Lichtenberger, University of Konstanz
- *
  */
 public final class LZ4Compressor implements ByteHandler {
 
   @Override
   public OutputStream serialize(final OutputStream toSerialize) {
-    try {
-      return new LZ4FrameOutputStream(toSerialize);
-    } catch (IOException e) {
-      throw new UncheckedIOException(e);
-    }
+    return new LZ4BlockOutputStream(toSerialize);
   }
 
   @Override
   public InputStream deserialize(final InputStream toDeserialize) {
-    try {
-      return new LZ4FrameInputStream(toDeserialize);
-    } catch (IOException e) {
-      throw new UncheckedIOException(e);
-    }
+    return new LZ4BlockInputStream(toDeserialize);
   }
 
   @Override

bundles/sirix-core/src/main/java/org/sirix/io/directio/FileChannelWriter.java

@@ -164,10 +164,11 @@ private FileChannelWriter writePageReference(final PageReadOnlyTrx pageReadOnlyT
 
       final byte[] serializedPage;
 
-      try (final ByteArrayOutputStream output = new ByteArrayOutputStream(byteArray.length);
-           final DataOutputStream dataOutput = new DataOutputStream(reader.getByteHandler().serialize(output))) {
-        dataOutput.write(byteArray);
-        dataOutput.flush();
+      try (final ByteArrayOutputStream output = new ByteArrayOutputStream(byteArray.length)) {
+        try (final DataOutputStream dataOutput = new DataOutputStream(reader.getByteHandler().serialize(output))) {
+          dataOutput.write(byteArray);
+          dataOutput.flush();
+        }
         serializedPage = output.toByteArray();
       }
 

bundles/sirix-core/src/main/java/org/sirix/io/file/FileWriter.java

@@ -140,12 +140,13 @@ private FileWriter writePageReference(final PageReadOnlyTrx pageReadOnlyTrx, fin
 
       final byte[] serializedPage;
 
-      try (final ByteArrayOutputStream output = new ByteArrayOutputStream(1_000);
-           final DataOutputStream dataOutput = new DataOutputStream(reader.byteHandler.serialize(output))) {
-        pagePersister.serializePage(pageReadOnlyTrx, byteBufferBytes, page, type);
-        final var byteArray = byteBufferBytes.toByteArray();
-        dataOutput.write(byteArray);
-        dataOutput.flush();
+      try (final ByteArrayOutputStream output = new ByteArrayOutputStream(1_000)) {
+        try (final DataOutputStream dataOutput = new DataOutputStream(reader.byteHandler.serialize(output))) {
+          pagePersister.serializePage(pageReadOnlyTrx, byteBufferBytes, page, type);
+          final var byteArray = byteBufferBytes.toByteArray();
+          dataOutput.write(byteArray);
+          dataOutput.flush();
+        }
         serializedPage = output.toByteArray();
       }
 

bundles/sirix-core/src/main/java/org/sirix/io/filechannel/FileChannelWriter.java

@@ -158,10 +158,11 @@ private FileChannelWriter writePageReference(final PageReadOnlyTrx pageReadOnlyT
 
       final byte[] serializedPage;
 
-      try (final ByteArrayOutputStream output = new ByteArrayOutputStream(byteArray.length);
-           final DataOutputStream dataOutput = new DataOutputStream(reader.getByteHandler().serialize(output))) {
-        dataOutput.write(byteArray);
-        dataOutput.flush();
+      try (final ByteArrayOutputStream output = new ByteArrayOutputStream(byteArray.length)) {
+        try (final DataOutputStream dataOutput = new DataOutputStream(reader.getByteHandler().serialize(output))) {
+          dataOutput.write(byteArray);
+          dataOutput.flush();
+        }
         serializedPage = output.toByteArray();
       }
 

bundles/sirix-core/src/main/java/org/sirix/io/iouring/IOUringWriter.java

@@ -178,10 +178,11 @@ private IOUringWriter writePage(PageReadOnlyTrx pageReadOnlyTrx, PageReference p
 
       final byte[] serializedPage;
 
-      try (final ByteArrayOutputStream output = new ByteArrayOutputStream(byteArray.length);
-           final DataOutputStream dataOutput = new DataOutputStream(reader.getByteHandler().serialize(output))) {
-        dataOutput.write(byteArray);
-        dataOutput.flush();
+      try (final ByteArrayOutputStream output = new ByteArrayOutputStream(byteArray.length)) {
+        try (final DataOutputStream dataOutput = new DataOutputStream(reader.getByteHandler().serialize(output))) {
+          dataOutput.write(byteArray);
+          dataOutput.flush();
+        }
         serializedPage = output.toByteArray();
       }