Skip to content

Conversation

@Peter0x44
Copy link
Contributor

@Peter0x44 Peter0x44 commented Oct 6, 2025

This is a continuation of #72, the changes I added were to make caching work, so the CI doesn't have to download tarballs on every run.

I am not sure if the changes to the Dockerfile are necessary. I initially made them because exporting the image to layers or something like that was hanging, and it fixed that. Docker is not something I have a lot of knowledge about. My changes were LLM authored, but I did test them as thoroughly as I could.

They are not. Removed.

Semphriss and others added 2 commits September 30, 2025 23:06
Now, the workflow doesn't download tarballs on every run.
@Peter0x44
Copy link
Contributor Author

The changes to the Dockerfile seem to be required. I removed them in https://github.com/Peter0x44/w64devkit/actions/runs/18278436300/job/52035735401 and it hung.

@Peter0x44
Copy link
Contributor Author

I managed to remove the changes to the Dockerfile, it still works.

@Peter0x44
Copy link
Contributor Author

Peter0x44 commented Oct 9, 2025

OK. There are still a few issues with this.

for PRs, it runs 2x the builds it needs to.
image

this might just be an issue with docker in general, but I had to update one of gcc's patches, but it did not invalidate the cache for x-gcc and continued using the previously cached build.

@Peter0x44
Copy link
Contributor Author

I fixed the duplicate runs on pull requests. Should be good to merge @skeeto .

@Peter0x44 Peter0x44 force-pushed the master branch 5 times, most recently from 7b0d096 to f86ca3d Compare October 10, 2025 02:12
@Peter0x44
Copy link
Contributor Author

No. I can't get that working.
But at least it cancels the jobs quickly after they start.

@Peter0x44 Peter0x44 force-pushed the master branch 2 times, most recently from 5942be1 to ad1624e Compare October 15, 2025 00:34
@Peter0x44 Peter0x44 mentioned this pull request Oct 15, 2025
@Peter0x44
Copy link
Contributor Author

@skeeto any objections left? I would love to get this in, I'm using it heavily.
It's being used in all of my experimental/research branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants