Firebase gaps...

[stallent]

New to Skip so still getting my sea legs, so to speak. I'm finding a few things missing in the skip-firebase package and was curious the best path forward. For example, the app i'm working to port uses PhoneAuthProvider from the iOS sdk which isn't yet in there. Are folks forking skip-firebase and adding what they need? Or is there some other better approach? Thanks!

[marcprux]

Much of our Firebase functionality has been added through pull requests. The recommended approach is to fork the repository and add your fork's local clone to an Xcode workspace alongside your app project so that it can be developed in tandem with your app, and then when you have the functionality you need ready to go, file a new PR from your fork. We describe the process at https://skip.tools/docs/contributing/#local-libraries.

Let us know if there is anything we can help with!

[stallent]

@marcprux Thank you. The biggest issue is there is no code or examples that illustrates how numeric types come back from Firestore. Even the example FireSide project, the Message type only shows strings and dates. This should be straight forward but goodness i cannot for the life of me figure out how to convert an Any that is coming back from a Number field in firestore to a usable Double on the swift side. DocumentSnapshot.get(fieldName) works great for String. Works great for Date (via firestore's dumb Timestamp type). But any number time works on the iOS side but not on the transpiled kotlin side. Suggestions on best way to debug?

[marcprux]

Oh, it's an Optional<Optional<Double>> for some reason. Can you cast it as Double???

[stallent]

i cannot. thats what i have been trying all day. weirdest damn thing.

[stallent]

it works for top level numbers if i implement

#if os(Android)

extension DocumentSnapshot {
    
    func getDouble(_ fieldName:String) throws -> Double {
        return try self.doc.getDouble(fieldName) ?? 0
    }
    
}
#endif

but again, only for top level number fields. If its a json field the nested numbers still are the uncastables. I've tried reflection via mirror to see if i can find what it thinks is deep down there but zero luck

[stallent]

its basically appearing to be ignorant of the underlayiing value. Its effectively treating it like an Optional<Optional<Any>> and what little reflection i coudl get working confirmed that.

[stallent]

type(of:data["durationInMinutes"]) returns Optional<Any> on both iOS and Android, but i can cast as Double on iOS but cannot on Android. Apologies for the partially redundant responses but trying to gather as much detail as possible

[stallent]

@marcprux I have additional info... I have found a workaround but i suspect there is some lower level issue... Its an issue with this method in SkipFirebaseFirestore...

fileprivate func deepSwift(value: Any) -> Any {
    if let str = value as? String {
        return str // needed to not be treated as a Collection
    } else if let ts = value as? com.google.firebase.Timestamp {
        return Timestamp(timestamp: ts)
    } else if let map = value as? kotlin.collections.Map<Any, Any> {
        return deepSwift(map: map)
    } else if let collection = value as? kotlin.collections.Collection<Any> {
        return deepSwift(collection: collection)
    } else {
        return value
    }
}

The ifs all work fine, but the final else. If the resulting value:Any is a kotlin.Bool it casts successfully as an Optional back on the swift side. if its a kotlin.Long (or Double) it does NOT cast properly. I can mod the final else to this as a workaround but feels weird.

} else {
    if let v = value as? kotlin.Long {
         return v.toInt()
    } else if let v = value as? kotlin.Double {
        return v.toDouble()
    } else {
        return value
    }
 }

Should that be necessary? Thank you!